feat(bench): expose min/max/stddev/P95 in benchmark reports#89
Merged
Conversation
Replace the single "Spread" tooltip column with four explicit tail-latency
columns (Min, Max, StdDev, P95) in all HTML benchmark tables — both the
zerodep vs. reference comparison tables and the standalone tables.
Key changes:
- Rename _spread_cell() → _tail_cells() which now renders four <td> elements
instead of one, so min/max/stddev/P95 are always visible without hovering
- Use a two-row <thead> with colspan grouping headers ("zerodep tail latency"
/ "Ref tail latency") to keep the wider table readable
- Wrap all tables in <div class="table-wrap"> (overflow-x: auto) so the page
stays usable on narrow viewports
- P95 is computed from stats.data when present; falls back to "—" when absent
(backward compatible with older JSON that omits the data array)
- Both _generate_html() and _generate_module_page() updated consistently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81.
The benchmark HTML report previously hid tail-latency stats (min, max, stddev, P95) behind a tooltip on a single "Spread" column. This PR makes them first-class visible columns.
Spreadcolumn with four explicit tail-latency columns: Min, Max, StdDev, P95 — both for zerodep and for the reference implementation<thead>withcolspangroup headers ("zerodep tail latency" / "Ref tail latency") so the wider table stays readable<div class="table-wrap">(overflow-x: auto) for narrow-viewport usabilitystats.datawhen present; gracefully falls back to—when the array is absent (backward compatible with older JSON)_generate_html()and_generate_module_page()updated consistently_spread_cell()→_tail_cells()to reflect its new semanticsTest plan
stats.datapresent — all four tail-latency columns rendered correctlystats.data— P95 shows—, no crash (backward compat verified)