-
-
Notifications
You must be signed in to change notification settings - Fork 92
enforce pnpm usage and prevent npm installs #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gurkiratcodemaster
wants to merge
2
commits into
OWASP:master
Choose a base branch
from
Gurkiratcodemaster:enforce-pnpm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,14 @@ | |
|
|
||
| https://cornucopia.owasp.org contains the card browser for each of the cards in the cornucopia suits together with the taxonomy and in depth explaination for each of the cards in the suits. | ||
|
|
||
| ## Development server | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please move tgis down to the other development server section and remove this headline as it is a duplicate. |
||
|
|
||
| This project uses **pnpm** for dependency management. | ||
| Please do **not use npm or yarn**, as mixing package managers can cause dependency conflicts. | ||
|
|
||
|
sydseter marked this conversation as resolved.
|
||
| ## Production build | ||
|
|
||
| npm run productionbuild | ||
| pnpm run productionbuild | ||
|
|
||
| ## Release to Cloudflare | ||
|
|
||
|
|
@@ -21,15 +26,14 @@ NB: The CLOUDFLARE_API_TOKEN needs to be renewed once a year. | |
|
|
||
| ## Development server | ||
|
|
||
| # npm install will raise a conflict | ||
| pnpm install # https://pnpm.io/installation | ||
| npm run dev | ||
| pnpm run dev | ||
|
|
||
| ## Testing and Code Coverage | ||
|
|
||
| Run tests with coverage reporting: | ||
|
|
||
| npm run test | ||
| pnpm run test | ||
|
|
||
| View coverage thresholds and results in the terminal output. Coverage reports are generated in the `./coverage` directory with the following formats: | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gurkiratcodemaster are these chaanges requiered?