feat: Implement atomic operations and rate limiting#2566
Open
khushal-winner wants to merge 3 commits intoOWASP:masterfrom
Open
feat: Implement atomic operations and rate limiting#2566khushal-winner wants to merge 3 commits intoOWASP:masterfrom
khushal-winner wants to merge 3 commits intoOWASP:masterfrom
Conversation
khushal-winner
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
sydseter
requested changes
Mar 12, 2026
Collaborator
sydseter
left a comment
sydseter
left a comment
There was a problem hiding this comment.
This may not work on fly, but I’ll try it out.
Contributor
Author
|
@sydseter , fixed the changes |
Collaborator
|
@khushal-winner could you resolve the conflicts? |
Contributor
Author
@sydseter yes i have resolved the conflicts now |
Collaborator
|
Still there. |
khushal-winner
force-pushed
the
feat/rate-limiting-atomic-operations
branch
2 times, most recently
from
fc79ce4 to
03589ed
Compare
…ct resolution - Add atomic card play operations to prevent race conditions - Implement rate limiting for API endpoints - Add comprehensive test coverage for rate limiting - Resolve merge conflicts with upstream improvements - Enhance error handling and validation in api_controller.ex
khushal-winner
force-pushed
the
feat/rate-limiting-atomic-operations
branch
from
03589ed to
de23b62
Compare
Contributor
Author
|
@sydseter , is everything clear for merging? |
Collaborator
|
@khushal-winner The test coverage has gone down. Please make sure it's higher then on master: https://github.com/OWASP/cornucopia/actions/runs/24130754439/job/70406497565 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes - #2559
Security improvements: prevents DoS attacks and race conditions