Save track fiducial sigma for all tracks, not just vetoed tracks#296
Open
Save track fiducial sigma for all tracks, not just vetoed tracks#296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The framework has 2 variables for every track that aren't currently being calculated:
maxSigmaForFiducialElectronTrackandmaxSigmaForFiducialMuonTrack. These variables are supposed get the worst performing inefficiency sigma in a detector region around the track. This can be useful for determining where to place a fiducial cut or for debugging purposes.However, these values currently are only stored on tracks that get vetoed by the fiducial cut. For all other tracks, this gets set to 0. That is not ideal for two reasons:
This change saves these variables properly for all tracks regardless of if they get vetoed or not.
Related
DisappTrksPR: OSU-CMS/DisappTrks#127Implementation Details
It was necessary to change how we handle the fiducial map. Previously,
OSUGenericTrackProducerwould go calculate the fiducial map and then save a list of all hot spots. The hot spots were given toTrackBase, which would then compare if they were close to any given hot spot.This changes it so the entire fiducial map
TH2Dgets sent toTrackBase, not just the hot spots. ThenTrackBaseindexes into the histogram based on its own eta and phi coordinate.Visualization
Here is a plot that shows what this change gets us. In the previous version of the code, all tracks with a max sigma < 2.0 would be assigned a max sigma of 0, so we wouldn't see the entire distribution.
Verification
I verified that no regression was made using 20,000 events for a 2024C ROOT file with the ElectronTagPt55 selection. The cutflow plots matched (indicating the veto logic is the same), and the sigma distribution showed no events above the 2.0 threshold.