Service Alerts API#8
Merged
Merged
Conversation
Adjust Deserialization test to include duplicated translations, as this is a failure case when parsing into the model. Deserialization should succeed here as the standard says nothing about this case, but transforming to the exported model should fail, as there is no logical reason to include two translations for the same language code.
Add a Service Alerts API to retrieve live service alert data, and provide a test to make sure this API provides expected values (mocking the network request)
Add endpoint for getting service alerts within a TransitClient. Adjust transit client construction to use IHttpClientFactory // DI, allowing for mocking of the HTTP Client in tests Rename Gtfs_RealtimeClient.cs to TransitClient.cs, test using TransitClient (Gtfs should be private to the library)
Transit clients that are not the main TransitClient class should be internal, they should never be touched by the main app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.