Added support for split-beam angle computation with mixed channel beam types in complex mode#1492
Conversation
…m types in complex mode
|
I couldn't figure out how to download the test data used in the existing tests, so the test file used in the unit test from this PR is a best guess. |
|
@beatfactor: the first command in this section will pull all the test files down, and you can stop the other services afterwards. |
|
@leewujung Thanks, I managed to download the data by avoiding running the compose script and I added a small script Lastly, I'm not sure about the check for dask arrays in the |
|
hey @leewujung, any updates here? could you re-trigger the build please? |
|
@beatfactor : Thanks for the reminder - I just re-triggered the tests and looks like everything runs fine. I am pretty swamped for the past weeks and hopefully will be able to look at the code changes later next week. |
|
@beatfactor : somehow the pre-commit.ci pushes were skipped. Could you please add the suggested changes into the code? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
+ Coverage 83.52% 84.92% +1.39%
==========================================
Files 64 79 +15
Lines 5686 7016 +1330
==========================================
+ Hits 4749 5958 +1209
- Misses 937 1058 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ok, done. Yes, it seems that the build won't push the changes if the PR is sent from a Github organization, which it is in this case. Thanks! |
This PR adds support for computing split-beam angles in datasets where only a subset of channels have valid
beam_typevalues (e.g.,beam_type = 1, 17, 49, 65, 81). It applies specifically to CW complex data.Previously, the presence of an unsupported
beam_typewould raise aValueError.Changes:
get_angle_complex_samples()to process each channel individually ifbeam_typeis not uniform;beam_typevalues and logs a warning instead of failing.