[389] Add support for bio data ingest from postgres db#415
[389] Add support for bio data ingest from postgres db#415dbashford-NOAA wants to merge 12 commits intoOSOceanAcoustics:mainfrom
Conversation
|
Quick recap from email exchanges between me and @dbashford-NOAA :
|
|
@dbashford-NOAA I see that you are running into similar issues with |
6db6f63 to
0e8370f
Compare
|
@brandynlucca Thanks for the help! I ended up pinning |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
33572ae to
be85236
Compare
for more information, see https://pre-commit.ci
|
@leewujung @brandynlucca It looks like the tests are failing because of the |
You need to also add it to |
1f7d2e9 to
6d492ae
Compare
|
@leewujung @brandynlucca There may be a way around this by running the windows tests in the workflow as a non-admin user but that could cause problems with other part of the process. I also tried setting up a docker container service to run the postgres db in the workflow but that's only supported for linux so the tests failed for macos and windows. Another solution could be to have an external postgres db setup to test against but I'm not sure where that would live or how we would manage credentials. Let me know if you have any ideas! |
|
@dbashford-NOAA : this is interesting - looks like this action would be helpful? https://github.com/marketplace/actions/setup-postgresql-for-linux-macos-windows |
100b803 to
6c8ca04
Compare
5e29792 to
a280419
Compare
|
@leewujung |
|
@dbashford-NOAA : Awesome! I am glad it worked out! Looking forward to reviewing this (and all the other reviews I owe you...). |
leewujung
left a comment
There was a problem hiding this comment.
Hey @dbashford-NOAA: Thanks for the PR and making postgres tests in CI work!
I think this PR is almost ready to go, just have some consistency issues that I marked in inline comments.
In addition, how about changing the biodata loading function names so that it is clear where the data are from?
load_biological_data-->load_biological_data_excelload_db_biological_data-->load_biological_data_database
|
@leewujung |
leewujung
left a comment
There was a problem hiding this comment.
@dbashford-NOAA : Great, thanks! Everything looks fine. I will merge this after the hackday tomorrow in case of breaking something due to the function name change for the bio data ingestion part.
|
For visibility: After the hack day we found out that the database that has been worked on was not the correct one, so more changes is needed on the database end. I'll hold on to reviewing / merging this until that is resolved. We have a meeting tomorrow (Jan 30) that will hopefully resolve this. |
|
Following up on this and after checking with Wu-Jung today, @dbashford-NOAA please ensure that the updated materialized views in the nwfsc_public_prod.acoustics schema match the previous views developed, and then go ahead and update the |
|
Let's flesh this out at our meeting tomorrow. I thought we agreed to use
trimmed down versions of just catch and specimen (that includes all length
fish as well).
…--
Alicia Billings, M.S.
Fishery Biologist
NOAA/NMFS/NWFSC/FRAM/FEAT
2032 Marine Science Drive
Newport, OR 97365
541.275.1742 Google voice
On Mon, Feb 2, 2026 at 2:06 PM Elizabeth Phillips ***@***.***> wrote:
*ElizabethMPhillips* left a comment (OSOceanAcoustics/echopop#415)
<#415 (comment)>
Following up on this and after checking with Wu-Jung today,
@dbashford-NOAA <https://github.com/dbashford-NOAA> please ensure that
the updated materialized views in the nwfsc_public_prod.acoustics schema
match the previous views developed, and then go ahead and update the
code to access the nwfsc_public_prod.acoustics schema. After that is
complete, we can test pulling the new, merged length view (that includes
both length and specimen in one table)
—
Reply to this email directly, view it on GitHub
<#415 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGZ752KVC2MXI7C2FSPNLVD4J7C67AVCNFSM6AAAAACKZZIAZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMZXGU4DKNJSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes - this is confirmed before/at the Feb 19 meeting. From Feb 19 notes, these below can be added to the materialized view:
Current UID: {SHIP}-{SURVEY_ID}-{SPECIES_CODE}-{HAUL_NUMBER} Also @dbashford-NOAA : How are the views from the database coming along? Do you think you can finish this soon? There are recent codebase changes, so please merge the upstream to your PR. Since it's been so long and there are going to be new changes coming up from @brandynlucca to use the catch and specimen, to avoid confusion, I think it'll be better if you revert the function name |
|
@leewujung I'll work on pulling in the upstream changes and I can revert the function name too. |
|
Sounds good - thanks @dbashford-NOAA ! |
|
@dbashford-NOAA : Just a quick note that once #463 is merged you could go ahead to make the changes. That PR should include all the handling needed to use the single specimen file (combining the previous specimen and length files) plus the catch file for running the workflow. |
Resolves #389
psycopgpackage to connect to postgres