fix #82 datumgrid added for Hungarian national projection elevation system by OSGeoLabBp · Pull Request #97 · OSGeo/proj-datumgrid

OSGeoLabBp · 2019-12-18T21:26:36Z

No description provided.

rouault

Has EPSG been approached to register those 2 grids ?

rouault · 2019-12-18T21:30:57Z

europe/README.EUROPE

-* ISL
+* ISL
+
+### Hungary: ETRS89 HD72/EOV (EPSG:23700)


can you move that before the "## Included init-files" section ?

There was no approache to EPSG so far.

There was no approache to EPSG so far.

As underlined in CONTRIBUTING.md, that would be very good to do so, otherwise PROJ has to act as a 'geodetic registry' to create custom database records that register the transformation grids. EPSG has much more experience than us to do that and in a consistent way

rouault · 2019-12-18T21:32:28Z

europe/README.EUROPE

+*Format*: NTv2
+*License*: [Creative Commons Attribution 4.0](https://creativecommons.org/licenses/by/4.0/)
+
+Grid transformation from ETRS89 to HD72/EOV.


is it offsets from ETRS89 to HD72 ? This is slightly unusual, and against the EPSG practice to go from "local" to "global" CRS

hum, HD72/EOV is a projected CRS.... Don't you mean the geographic 2D CRS EPSG:4237 instead ?

I've tried to compare with the Helmert-based transformation included in EPSG, EPSG:1449, HD72 to ETRS89 (2)

$ echo "20 47 0" | src/cct -d 8 +proj=pipeline +proj=unitconvert +xy_in=deg +xy_out=rad +step +proj=push +v_3 +step +proj=cart +ellps=GRS67 +step +proj=helmert +x=52.684 +y=-71.194 +z=-13.975 +rx=0.312 +ry=0.1063 +rz=0.3729 +s=1.0191 +convention=coordinate_frame +step +inv +proj=cart +ellps=GRS80 +step +proj=pop +v_3 +step +proj=unitconvert +xy_in=rad +xy_out=deg 19.99887740 46.99973951 0.00000000 inf

I do get a compatible result when using

$ echo "20 47 0" | src/cct -d 8 +proj=pipeline +step +proj=hgridshift +grids=etrs2eov_notowgs.gsb 19.99887893 46.99973967 0.00000000 inf

So this means that this grid is from HD72 to ETRS89. It should likely be renamed so that it is obvious

The offsets are between EPSG:23700 and EPSG_4258. The HD72/EOV refers to both the datum and projection system. I don't why this name is used. The cs2cs command is:
cs2cs -f "%.7f" +init=epsg:23700 +nadgrids=etrs2eov_notowgs.gsb +geoidgrids=geoid_eht2014.gtx +to +init=epsg:4258

he offsets are between EPSG:23700 and EPSG_4258

That doesn't make sense from a modelization point of view. A NTv2 grid is the correction between 2 geographic CRS. Of course it can be (indirectly) applied to a projected CRS based on them, such as EPSG:23700 is based upon EPSG:4237, but from a documentation point of view, only the geographic CRS must be documented. That is this grid is from EPSG:4237 (HD72) to EPSG:4258 (ETRS89)

rouault · 2019-12-18T21:37:11Z

filelist.csv

 g2018u0.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,,EPSG:6319,EPSG:5703,,us_noaa,NOAA,Public Domain
 g2018p0.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,,EPSG:6319,EPSG:6641,,us_noaa,NOAA,Public Domain
+etrs2eov_notowgs.gsb,HORIZONTAL_OFFSET,,EPSG:4258,EPSG:23700,,BME-GEOD,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/
+geoid_eht2014.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,EPSG:4258,EPSG:23700,EPSG:4258,,BME-GEOD,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/


wrong EPSG codes for geoid_eht2014.gtx. Source should be EPSG:4937 (ETRS89 Geographic 3D CRS) and target I'm not sure, either EPSG:5705 (Baltic 1977 height) or EPSG:5786 (Baltic 1982 height) or 'EPSG:8357 (Baltic 1957 height)

rouault · 2019-12-18T21:37:42Z

europe/README.EUROPE

+
+* etrs2eov_notowgs.gsb
+
+### Hungary: ETRS89 heights -> Baltic heights


which of the baltic heights ? EPSG references 3 versions: EPSG:5705 (Baltic 1977 height) or EPSG:5786 (Baltic 1982 height) or 'EPSG:8357 (Baltic 1957 height)

rouault · 2019-12-18T21:42:36Z

filelist.csv

 g2012bp0.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,,EPSG:6319,EPSG:6641,,us_noaa,NOAA,Public Domain
 g2018u0.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,,EPSG:6319,EPSG:5703,,us_noaa,NOAA,Public Domain
 g2018p0.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,,EPSG:6319,EPSG:6641,,us_noaa,NOAA,Public Domain
+etrs2eov_notowgs.gsb,HORIZONTAL_OFFSET,,EPSG:4258,EPSG:23700,,BME-GEOD,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/


EPSG:23700 shoud likely be EPSG:4237 instead .

For the agency_name colum, can you use hu_bme_geod ? for that record and the next one

rouault · 2019-12-18T21:43:33Z

and could you rebase against latest master ?

rouault · 2019-12-22T10:27:13Z

europe/README.EUROPE

 ISN_vel_beta.ct2 
 ISN_vel_beta.gtx

+### Hungary: HD72/EOV (EPSG:23700) ETRS89


Suggested change

### Hungary: HD72/EOV (EPSG:23700) ETRS89

### Hungary: HD72 (EPSG:4237) ETRS89

rouault · 2019-12-22T10:28:11Z

europe/README.EUROPE

+*Format*: NTv2
+*License*: [Creative Commons Attribution 4.0](https://creativecommons.org/licenses/by/4.0/)
+
+Grid transformation from HD72/EOV to ETRS89.


Suggested change

Grid transformation from HD72/EOV to ETRS89.

Grid transformation from HD72 to ETRS89 (typically applied for transformations from projected CRS HD72/EOV (EPSG:23700) to ETRS89)

rouault · 2019-12-22T10:29:44Z

filelist.csv

 g2018u0.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,,EPSG:6319,EPSG:5703,,us_noaa,NOAA,Public Domain
 g2018p0.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,,EPSG:6319,EPSG:6641,,us_noaa,NOAA,Public Domain
+etrs2eov_notowgs.gsb,HORIZONTAL_OFFSET,,EPSG:4258,EPSG:8357,,hu_bme_geod,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/
+geoid_eht2014.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,EPSG:4258,EPSG:23700,EPSG:4258,,hu_bme_geod,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/


Suggested change

geoid_eht2014.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,EPSG:4258,EPSG:23700,EPSG:4258,,hu_bme_geod,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/

geoid_eht2014.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,EPSG:4937,EPSG:8357,,,hu_bme_geod,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/

rouault · 2020-01-12T14:15:22Z

Can you address the review comments and rebase on top of latest master to fix the conflict in filelist.csv ?

rouault · 2020-01-29T17:09:58Z

WARNING: This repository is no longer open for adding new datasets. Starting with PROJ 7, the PROJ-data repository is the new home for PROJ datasets.

Go to its CONTRIBUTING instructions

datumgrid added for Hungarian national projection elevation system

4071272

rouault suggested changes Dec 18, 2019

View reviewed changes

rouault reviewed Dec 18, 2019

View reviewed changes

OSGeoLabBp added 2 commits December 22, 2019 10:50

Updated to Even's comments

c256ba0

Update to Even's comments

597293b

rouault reviewed Dec 22, 2019

View reviewed changes

rouault mentioned this pull request Dec 29, 2019

Investigate ETRS2EOV.gsb (EOV/Balti -> ETRS89 for Hungary) #82

Open

brncsk mentioned this pull request Jul 20, 2021

Add Hungarian grids OSGeo/PROJ-data#68

Closed


		* etrs2eov_notowgs.gsb

		### Hungary: ETRS89 heights -> Baltic heights

	### Hungary: HD72/EOV (EPSG:23700) ETRS89
	### Hungary: HD72 (EPSG:4237) ETRS89

	Grid transformation from HD72/EOV to ETRS89.
	Grid transformation from HD72 to ETRS89 (typically applied for transformations from projected CRS HD72/EOV (EPSG:23700) to ETRS89)

	geoid_eht2014.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,EPSG:4258,EPSG:23700,EPSG:4258,,hu_bme_geod,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/
	geoid_eht2014.gtx,VERTICAL_OFFSET_GEOGRAPHIC_TO_VERTICAL,EPSG:4937,EPSG:8357,,,hu_bme_geod,www.geod.bme.hu,Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/

Conversation

OSGeoLabBp commented Dec 18, 2019

Uh oh!

rouault left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rouault commented Dec 18, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rouault commented Jan 12, 2020

Uh oh!

rouault commented Jan 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants