temporal: add explicit return True in shift()#7231
Open
selma-Bentaiba wants to merge 1 commit intoOSGeo:mainfrom
Open
temporal: add explicit return True in shift()#7231selma-Bentaiba wants to merge 1 commit intoOSGeo:mainfrom
selma-Bentaiba wants to merge 1 commit intoOSGeo:mainfrom
Conversation
shift() returns None on success but signature declares -> bool. Add explicit return True to match contract. Follow-up to OSGeo#7228
selma-Bentaiba
force-pushed
the
fix-shift-return-type
branch
from
9ace12c to
4372527
Compare
ninsbl
approved these changes
Mar 28, 2026
selma-Bentaiba
pushed a commit
to selma-Bentaiba/grass
that referenced
this pull request
Mar 28, 2026
Introduces unittests_temporal_stds_management.py with dedicated coverage for core management methods that had no existing tests. - test_shift_absolute_time: timestamps advance by the given granularity - test_shift_invalid_granularity: regression test for OSGeo#7228, ensures invalid input returns False rather than a formatting TypeError - test_snap_closes_gaps: end times are snapped to next map's start time test_shift_relative_time is commented out because relative time unit type resolution fails in GRASS 7.8.7 with 'unsupported unit type: None'. Needs verification against GRASS 8.x once OSGeo#7231 is merged. Related: OSGeo#7228 (fix string formatting in fatal error messages) OSGeo#7231 (add explicit return True in shift())
selma-Bentaiba
pushed a commit
to selma-Bentaiba/grass
that referenced
this pull request
Mar 28, 2026
Introduces unittests_temporal_stds_management.py with dedicated coverage for core management methods that had no existing tests. - test_shift_absolute_time: timestamps advance by the given granularity - test_shift_invalid_granularity: regression test for OSGeo#7228, ensures invalid input returns False rather than a formatting TypeError - test_snap_closes_gaps: end times are snapped to next map's start time test_shift_relative_time is commented out because relative time unit type resolution fails in GRASS 7.8.7 with 'unsupported unit type: None'. Needs verification against GRASS 8.x once OSGeo#7231 is merged. Related: OSGeo#7228 (fix string formatting in fatal error messages) OSGeo#7231 (add explicit return True in shift())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7228
shift() method returns None on success but signature declares -> bool.
Add explicit return True to match the documented contract.
Currently works because caller uses
is Falsestrict check,but correct behavior should return bool as documented.