Draft
Conversation
Contributor
|
I have #6465 open, see if there is some overlap. |
Contributor
Author
|
There is some overlap with accessing the CRS information that would make more sense as part of the other PR, but this PR is still addressing other issues. I will add a review with my suggested addition to PR #6465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds COPC support improvements to r.in.pdal, by making spatial reference handling robust for COPC-style readers and exposing a performance tuning option for point buffering.
I also cleaned up the grassrasterwriter, so the constructor now initializes additional members explicitly. Previously, Z dimension data was getting written only as 0 and null during binning. And I set the edge of region point notice changed from to debug-level output to potential help with performance when parsing through large point clouds.
I still need to add tests so it's a draft for now.