doc: Modernize segment library examples and documentation#7035
Open
Abhi-d-gr8 wants to merge 9 commits intoOSGeo:mainfrom
Open
doc: Modernize segment library examples and documentation#7035Abhi-d-gr8 wants to merge 9 commits intoOSGeo:mainfrom
Abhi-d-gr8 wants to merge 9 commits intoOSGeo:mainfrom
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
7d345eb to
3f785fa
Compare
wenzeslaus
requested changes
Feb 4, 2026
Member
wenzeslaus
left a comment
There was a problem hiding this comment.
We now use also CMake and I think the examples are compiled somewhere in the CI.
Contributor
Author
|
Thanks for the feedback, @wenzeslaus ! I've now added CMake support for these examples and verified that they compile correctly. I also fixed the end-of-file newlines that the bot flagged. |
Member
|
This should not compile always, at the same time it needs to compile in the CI with the other examples. While I appreciate the old PR cleanup, this needs more in depth work. If one AI run were enough, I would have merged that already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseding #20.
Changes:
r.example.segmentandr.example.segmulti) from HTML to Markdown to match current GRASS GIS standards.Reference: