Skip to content

doc: Modernize segment library examples and documentation#7035

Open
Abhi-d-gr8 wants to merge 9 commits intoOSGeo:mainfrom
Abhi-d-gr8:fix/pr-20-segment-docs
Open

doc: Modernize segment library examples and documentation#7035
Abhi-d-gr8 wants to merge 9 commits intoOSGeo:mainfrom
Abhi-d-gr8:fix/pr-20-segment-docs

Conversation

@Abhi-d-gr8
Copy link
Contributor

Superseding #20.

Changes:

  • Rebases the original improvements by @wenzeslaus onto the current main branch.
  • Resolves all merge conflicts in lib/segment/segmentlib.dox, open.c, and get_row.c.
  • Converts the documentation for the new example modules (r.example.segment and r.example.segmulti) from HTML to Markdown to match current GRASS GIS standards.
    Reference:
  • Original PR: man: Improve segment library documentation, provide examples #20
  • Fixes the request for Markdown conversion and conflict resolution.

@github-actions github-actions bot added C Related code is in C libraries docs markdown Related to markdown, markdown files labels Feb 4, 2026
@Abhi-d-gr8 Abhi-d-gr8 force-pushed the fix/pr-20-segment-docs branch from 7d345eb to 3f785fa Compare February 4, 2026 03:51
@Abhi-d-gr8 Abhi-d-gr8 changed the title Modernise segment library examples and documentation (Supersedes #20) doc: Modernize segment library examples and documentation Feb 4, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now use also CMake and I think the examples are compiled somewhere in the CI.

@Abhi-d-gr8
Copy link
Contributor Author

Thanks for the feedback, @wenzeslaus ! I've now added CMake support for these examples and verified that they compile correctly. I also fixed the end-of-file newlines that the bot flagged.

@github-actions github-actions bot added the CMake label Feb 4, 2026
@wenzeslaus
Copy link
Member

This should not compile always, at the same time it needs to compile in the CI with the other examples.

While I appreciate the old PR cleanup, this needs more in depth work. If one AI run were enough, I would have merged that already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C CMake docs libraries markdown Related to markdown, markdown files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants