r.watershed: Add comprehensive tests for map reuse functionality#6992
Open
sumitchintanwar wants to merge 4 commits intoOSGeo:mainfrom
Open
r.watershed: Add comprehensive tests for map reuse functionality#6992sumitchintanwar wants to merge 4 commits intoOSGeo:mainfrom
sumitchintanwar wants to merge 4 commits intoOSGeo:mainfrom
Conversation
github-actions
bot
added
raster
Deactivate CI for TestWatershedReuseLarge until parameters
sumitchintanwar
force-pushed
the
fix/add-test-r-watershed
branch
from
508330b to
61dd278
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive tests for the map reuse functionality. As asked in PR #6953.
The reuse functionality reuses the calculated maps instead of recalculating them again, which saves time and a lot of computational power.
The PR adds three classes of tests:
Tests use
@unittest.expectedFailuredecorator since accumulation_input and drainage_input parameters are not yet implemented. This allows tests to run in CI without failing the build. Once that feature is merged, The@unittest.expectedFailurewill be removed in a follow up commit.Verification: All tests run successfully locally with the implemented changes, passing with 0 errors
Also, Tests for TCI/SPI calculation and basin delineation with reused maps are not included in this PR, as these features require significant algorithm changes and will be addressed in separate follow-up work once the core map reuse functionality is stable.