g.extension: fix getting addon directories names without Py/C source code

[tmszi]

Fixes #4761.

[ninsbl]

Looks good. You may consider adding a test for this case!?!

[echoix]

I suggested some changes for some small typos that were obvious to me. I didn't really analyze if the messages make sense in the context, I limited myself to the words

[tmszi]

Looks good. You may consider adding a test for this case!?!
Test is included

Looks good. You may consider adding a test for this case!?!

Test is included (I extended it with commit bc19b1f):

grass/scripts/g.extension/testsuite/test_addons_download.py

Lines 218 to 234 in 46d2bac

	def test_github_install_official_multimodule_and_check_metadata(self):
	"""Test installing multi-module extension from official addons
	repository without printing warning no metadata available message
	for module wich install HTML page file only"""
	extension = "i.sentinel"
	gextension = SimpleModule(
	"g.extension",
	extension=extension,
	prefix=str(self.install_prefix),
	)
	self.assertModule(gextension)
	self.assertTrue(gextension.outputs.stderr)
	self.assertNotIn(
	_("No metadata available for module '{}':").format(extension),
	gextension.outputs.stderr,
	)

[echoix]

At one point we'll need to think about what to do when html man pages might not be the only thing. When using markdown as source, will the addon install a "compiled" page that will HTML (processed from the markdown), or only the source file?

[petrasovaa]

Looks like the test failed:

======================================================================
FAIL: test_github_download_official_module_src_code_only (__main__.TestModuleDownloadFromDifferentSources)
Test download extension source code only from official addons
----------------------------------------------------------------------
Traceback (most recent call last):
  File "scripts/g.extension/testsuite/test_addons_download.py", line 193, in test_github_download_official_module_src_code_only
    self.assertTrue(ext_path.exists())
AssertionError: False is not true

----------------------------------------------------------------------
Ran 9 tests in 36.965s
FAILED (failures=1)
========================================================================
FAILED ./scripts/g.extension/testsuite/test_addons_download.py (1 test failed)

[neteler]

I don't know what's wrong in the CI. Locally it doesn't show problems:

cd scripts/g.extension/testsuite/ 
grass --tmp-project XY --exec python test_addons_download.py
[...]
Ran 9 tests in 64.323s
OK

[tmszi]

I don't know what's wrong in the CI. Locally it doesn't show problems:

cd scripts/g.extension/testsuite/ 
grass --tmp-project XY --exec python test_addons_download.py
[...]
Ran 9 tests in 64.323s
OK

On the local emulator terminal (during tests especially g.extension module) is printed to the stderr GRASS GIS command g.extension module output and debug info too. I enable debug mode beacuse I'm checking some debug variable value f"Addon name <{extension}> which install only HTML man page.", (line 240) bc19b1f.

Under CI is printed only debug info (not g.extension module output) and therefore this 'test_github_download_official_module_src_code_only' test fails.

[neteler]

On the local emulator terminal (during tests especially g.extension module) is printed to the stderr GRASS GIS command g.extension module output and debug info too. I enable debug mode beacuse I'm checking some debug variable value f"Addon name <{extension}> which install only HTML man page.", (line 240) bc19b1f.

Under CI is printed only debug info (not g.extension module output) and therefore this 'test_github_download_official_module_src_code_only' test fails.

Do we need to modify the CI test?

Waiting for tests to be fixed