Skip to content

startup: catch errors in build_modules_xml.py, grass.py#2686

Merged
neteler merged 2 commits into
OSGeo:mainfrom
neteler:python_scripterror_catch
Feb 13, 2023
Merged

startup: catch errors in build_modules_xml.py, grass.py#2686
neteler merged 2 commits into
OSGeo:mainfrom
neteler:python_scripterror_catch

Conversation

@neteler

@neteler neteler commented Dec 6, 2022

Copy link
Copy Markdown
Member

This PR is an extract from #348 (extracted and updated with black):

Not sure if we want these changes but just to avoid to see them lost when closing #348 in favour of #2684.

This PR is an extract from #348:
- gui/wxpython/tools/build_modules_xml.py edits: https://github.com/OSGeo/grass/pull/348/files#diff-11ca77721b6d009b6537c54be4172efed843021797676258ad1141a6c63e6fd1
- lib/init/grass.py: https://github.com/OSGeo/grass/pull/348/files#diff-647be4ef599868c33f2f69f0d899f79f0aee8d75d1db74f523268c1ac94cddf7

Not sure if we want these changes but just to avoid to see them lost when closing #348 in favour of #2684.
@neteler neteler added enhancement New feature or request Python Related code is in Python labels Dec 6, 2022
@neteler neteler added this to the 8.3.0 milestone Dec 6, 2022

@wenzeslaus wenzeslaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, this looks good.

I'm not sure about managing these small changes smartly for the release notes. It does not fit into these categories:

https://github.com/OSGeo/grass/blob/main/utils/release.yml

Comment thread lib/init/grass.py Outdated
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
@neteler neteler changed the title build_modules_xml.py, grass.py: catch errors startup: catch errors in build_modules_xml.py, grass.py Jan 12, 2023
@neteler

neteler commented Jan 12, 2023

Copy link
Copy Markdown
Member Author

I'm not sure about managing these small changes smartly for the release notes.

I have changed to use the "startup: ..." keyword.

@neteler neteler requested a review from wenzeslaus January 12, 2023 10:15
@neteler

neteler commented Jan 28, 2023

Copy link
Copy Markdown
Member Author

@wenzeslaus may I merge this PR? Not sure how to properly dismiss the "Changes requested" which I believe have been addressed.

@wenzeslaus

Copy link
Copy Markdown
Member

Dismiss review is in the details of the "change requested" section under the ... menu as Dismiss review which I think gives an option to say why it is no longer relevant. I agree that this is appropriate procedure for a small clearly defined change like this syntax fix, esp. with reviewer not revisiting the PR quickly.

The failure from Ubuntu / minimum config tests is unrelated to this PR (the old run cannot be restarted anymore).

@neteler neteler merged commit 20bba91 into OSGeo:main Feb 13, 2023
@neteler neteler deleted the python_scripterror_catch branch February 13, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Python Related code is in Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants