Fix Dropdown Arrow Direction for Latest New 2025#580
Open
KomatiBhavaniSankar wants to merge 1 commit intoOSGeo:masterfrom
Open
Fix Dropdown Arrow Direction for Latest New 2025#580KomatiBhavaniSankar wants to merge 1 commit intoOSGeo:masterfrom
KomatiBhavaniSankar wants to merge 1 commit intoOSGeo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @cwhite911, and maintainers,
First, I sincerely apologize for closing the previous PR without consulting you beforehand. That was an oversight on my part. Based on the review comments and suggestions, I have now carefully implemented the requested changes and raised this new PR. I hope this update is closer to the expected standard.
Regarding the “Latest News 2025” dropdown arrow behavior #575 :
I followed the suggested markup-based solution to avoid additional JavaScript. However, after testing, the toggle icon behavior still shows design error and I saw a limitation when relying purely on Bootstrap’s default behavior. From my investigation, this appears to be a Bootstrap constraint, and a minimal JavaScript solution would fully resolve the issue. I wanted to highlight this transparently in case using a small JS snippet is acceptable.
Output Screenshot based on Suggestion:
Important note about the hamburger menu (production issue)
I would also like to explicitly highlight that the hamburger menu is not working in the production site. While investigating this issue, I noticed that the codebase predominantly uses Bootstrap 4, but some components are already written using Bootstrap 5 conventions. This mix causes the hamburger menu to fail in production.
To prevent breaking existing behavior, I initially added the Bootstrap script in
themes/grass/layouts/partials/navigation.htmlrather than partially modifying markup.To address this properly and transparently, I opened a separate issue and PR:
This PR focuses on resolving the production hamburger menu issue in a cleaner and more consistent way.
Based on the feedback from the earlier PR (#576), I have also:
Thank you very much for your detailed reviews and guidance. I appreciate your patience and am happy to revise further based on your feedback.
Best regards,
Komati Bhavani Sankar