Skip to content

Fix use of vendored json when external is chosen #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdt wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix use of vendored json when external is chosen #4782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0ee364
NOMERGE: remove vendored json to prevent use
gdt May 22, 2026
e011380
CI fedora: Install nlohmann-json
gdt May 23, 2026
af85a5a
projsync: Pass define for external json
gdt May 22, 2026
980e84d
tests: Pass EXTERNAL_NLOHMANN_JSON definition
gdt May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/fedora_rawhide/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
set -e

dnf install -y cmake clang ccache ninja-build sqlite-devel libtiff-devel libcurl-devel diffutils wget
# For this build, install nlohmann-json so that the "use external"
# branch is tested; the other builds use the vendored copy.
dnf install -y nlohmann-json-devel

cd "$WORK_DIR"

Expand Down
Loading
Loading