Allow finding TPLs by environment variables#149
Allow finding TPLs by environment variables#149masterleinad wants to merge 1 commit intoORNL-CEES:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 53 53
Lines 2199 2199
=======================================
Hits 1930 1930
Misses 269 269Continue to review full report at Codecov.
|
Rombur
left a comment
There was a problem hiding this comment.
Let's not merge this. The build system and this part in particular is very brittle and it is too important to start making change to it at this time in the project. Passing the jenkins is not enough, we need to try on different machines.
This patch is armless and gives cleaner code in CMake. |
|
We can strip the part with the env variables if you don't like but this is the correct way to detect the AmgX lib and link against it. |
|
We shouldn't merge anything in the build system until we know it works on Docker, my machine, and Andrey's. |
Also provide an error message in case
AmgXwas not found.