PD-3625 Align visibility icon with the name value, not the label#2876
Merged
Conversation
Member
|
Task linked: PD-3625 Spacing and alignment in Names panel |
Addresses review feedback: the icon was centering against the whole label+value block, so it sat between the two lines instead of level with the bold name. Moves the caption label outside the icon's flex row so the row only ever contains the value (published name, or the given/family name when there's no published name) - this also makes the icon centre correctly when a long name wraps onto several lines. Also promotes the given/family name to the H1 $body-large style when there's no published name, per feedback.
cryptalith
force-pushed
the
lmendoza/PD-3625
branch
from
2b0222c to
9f45227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.