Skip to content

PD-5545 fix issn loader infinite loop #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontenegro merged 2 commits into from
May 28, 2026
+5 −2
Merged

PD-5545 fix issn loader infinite loop #7522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a0e6ef
PD-5545 flush batch before processing new one
aromanovv May 28, 2026
a8fdcfe
fix failed extraction logic
aromanovv May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions orcid-scheduler-web/src/main/java/org/orcid/scheduler/loader/source/issn/IssnLoadSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ private void updateIssnGroupIdRecords() {
updateIssnEntity(issnEntity, issnData);
LOG.info("Updated group id record {} - {}, processed count now {}",
new Object[]{issnEntity.getId(), issnEntity.getGroupId(), Integer.toString(total)});
} else {
LOG.warn("Extraction failed or returned null for ISSN: {}", issn);
recordFailure(issnEntity, "General extraction failure or null response");
}
} catch(TooManyRequestsException tmre) {
//We are being rate limited, we have to pause for 'pause' minutes
Expand Down Expand Up @@ -135,8 +138,8 @@ private void updateIssnGroupIdRecords() {
LOG.warn("InterruptedException for issn {}", issn);
recordFailure(issnEntity, "InterruptedException");
} catch(JSONException e) {
LOG.warn("InterruptedException for issn {}", issn);
recordFailure(issnEntity, "InterruptedException");
LOG.warn("JSONException for issn {}", issn);
recordFailure(issnEntity, "JSONException");
}
} else {
LOG.info("Issn for group record {} not valid: {}", issnEntity.getId(), issnEntity.getGroupId());
Expand Down
Loading