Sa692 soc prompts st2 st3#30
Open
peter-spencer-ons wants to merge 25 commits into
Open
Conversation
8 tasks
ivyONS
reviewed
Jun 2, 2026
ivyONS
reviewed
Jun 2, 2026
ivyONS
reviewed
Jun 2, 2026
ivyONS
reviewed
Jun 3, 2026
| Raises: | ||
| ValueError: If the number of candidates is not within the allowed range. | ||
| """ | ||
| if not 1 <= len(v) <= MAX_ALT_CANDIDATES: |
There was a problem hiding this comment.
does it really have to have at least 1 alt candidate?
Contributor
Author
There was a problem hiding this comment.
I think it is worth keeping at least one candidate in case we want to verify LLM's selection.
Also we have been using minimum number of candidates 1 for alt_candidates to ensure there is at least one.
There was a problem hiding this comment.
but if it is clearly codable and it assigned one code, there are unlikely any suitable alternatives, in such a case the list of alternative candidates should be empty
ivyONS
reviewed
Jun 3, 2026
ivyONS
reviewed
Jun 4, 2026
| - Company's main activity: {industry_descr} | ||
| - Job Title: {job_title} | ||
| - Job Description: {job_description} | ||
|
|
ivyONS
reviewed
Jun 5, 2026
| industry_descr: str, | ||
| job_title: str | None = None, | ||
| job_description: str | None = None, | ||
| level_of_education: str | None = None, |
There was a problem hiding this comment.
you have added the level of edu to the sa_rag_soc_code method but not to its prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Summary
Adds stage 2 and 3 in the two prompt SOC pipeline.
Changes in this PR are required for (ONSdigital/survey-assist-eval#9) to be tested.
Mirrors the same steps as in SIC pipeline (sic-classification-utils).
📜 Changes Introduced
Introduced changes to
✅ Checklist
terraform fmt&terraform validate)🔍 How to Test
Test in (ONSdigital/survey-assist-eval#9)