Update column (SA-674)#10
Merged
Merged
Conversation
This was referenced Apr 30, 2026
11 tasks
|
Hey, I can see the column name being updated, but the |
- keep lookup responses stable while tightening code path for example and configured data
Contributor
Author
@Tom-Owen-ONS, yes some missing commits, this should work now |
Tom-Owen-ONS
approved these changes
May 15, 2026
Tom-Owen-ONS
left a comment
There was a problem hiding this comment.
Works great now, thanks for updating :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Pull Request Template
✨ Summary
Align SIC rephrase example data and
SICRephraseLookupwith SA-674 naming: CSV columnreviewed_description→rephrased_description, and the same name onlookup()return values /process_jsonaccess.Breaking change (library API):
SICRephraseLookup.lookuppreviously returnedreviewed_description, it now returnsrephrased_description. Downstream code that read the old key must switch.📜 Changes Introduced
src/industrial_classification/data/example_rephrased_sic_data.csv— header: final column renamed torephrased_description.src/industrial_classification/lookup/sic_lookup.py—SICRephraseLookup: read that column; dict keyrephrased_description; docstring tweak.docs/example_data.md— table header updated.src/industrial_classification/lookup/sic_lookup_example.py— comment aligned.Feature implementation (feat:) / bug fix (fix:) / refactoring (chore:) / documentation (docs:) / testing (test:) — chore / data contract alignment (plus docs)
Updates to tests and/or documentation — docs + example module comment, tests unchanged (none covered
SICRephraseLookupdirectly)Terraform changes (if applicable) — N/A
✅ Checklist
Verified on 2026-05-01 from repo root with
poetry install(installs the package; required for imports) thenmake check-python-nofixandpoetry run pytest -q.poetry run black . --check(viamake check-python-nofix)poetry run isort . --check(via same target)poetry run bandit -r src/industrial_classification(same target)pytest— 10 passeddocs/example_data.md🔍 How to Test
cd sic-classification-library poetry install make check-python-nofix poetry run pytest -qOptional: run
sic_lookup_example.pyfrom repo root and confirm printedSICRephraseLookup.lookupoutput includesrephrased_description.