Skip to content

More bug fixes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angusgoody merged 2 commits into from
Apr 28, 2026
Merged

More bug fixes #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8fab8a
tweaked pydantic parsing
angusgoody Apr 28, 2026
518008b
bump
angusgoody Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/repositories/dataset_storage/firestore_dataset_storage_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ def get_latest_dataset_metadata(self, survey_id: str, period_id: str) -> Dataset
if len(datasets) == 0:
return None

return DatasetMetadataWithoutId.model_validate(datasets[0])
# Parse into Pydantic Model
return DatasetMetadataWithoutId.model_validate(
datasets[0].to_dict()
)

def _get_dataset_metadata(self, survey_id: str, period_id: str, version: int) -> DatasetMetadata | None:
latest_dataset = (
Expand All @@ -74,7 +77,9 @@ def _get_dataset_metadata(self, survey_id: str, period_id: str, version: int) ->
if len(datasets) == 0:
return None

return DatasetMetadata.model_validate(datasets[0])
return DatasetMetadata.model_validate(
datasets[0].to_dict()
)

def store_dataset(
self,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "sds-loader"
version = "0.1.3"
version = "0.1.4"
description = "A service for loading new SDS schemas and datasets"
requires-python = "==3.13.*"
dependencies = [
Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading