Choose CIR version for EQ formtype XXXX page - radio buttons - view permissions#1024
Open
matthew-robinson-ons wants to merge 5 commits into
Open
Choose CIR version for EQ formtype XXXX page - radio buttons - view permissions#1024matthew-robinson-ons wants to merge 5 commits into
matthew-robinson-ons wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
This PR updates the cir versions page radio buttons, for when the user on the page doesn't have edit permissions.
The acceptance criteria stated to have the radios be disabled but the design system doesn't implement a disabled variant of a radio button.
The approach taken is to provide a summary list of the available versions and a check mark next to a version if it has been selected. See conversation on the Jira ticket.
N.B. Have implemented technical task 1 from https://officefornationalstatistics.atlassian.net/browse/RAS-1665 to hide the save button as was easier to implement than not.
How to test?
Deploy this PR and set up a CIR collection exercise (QBS)
Add some form types and select some cir versions.
Setup up an account without edit survey permissions on the manage user accounts tab.
Navigate to surveys/QBS/PERIODREF/view-sample-ci/summary/FORMTYPE with and without edit permissions and ensure in both cases all the versions are visible and the selected version is shown to the user.
N.B. Due to the trade off with not having disabled radio buttons the user won't see a nothing selected option unless they have edit permissions.
Jira
https://officefornationalstatistics.atlassian.net/browse/RAS-1639