Skip to content

Upgrade reusable release workflow orchestration#30

Merged
jmcte merged 2 commits into
mainfrom
codex/release-workflow-orchestration
May 13, 2026
Merged

Upgrade reusable release workflow orchestration#30
jmcte merged 2 commits into
mainfrom
codex/release-workflow-orchestration

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented May 12, 2026

Summary

  • Add reusable release workflow metadata derivation, exact SemVer validation, and branch ancestry guards for main or matching release/X.Y refs.
  • Add optional version/build hooks, release notes file support, and safer ordering before floating tag promotion.
  • Address review feedback by rejecting zero-padded SemVer components before publish or floating tag updates.
  • Normalize manifest CI customization fields used by rendered workflow paths and custom scripts so the repo check gate typechecks.

Governing Issue

Closes #22

Validation

  • npm test -- tests/reusable-workflows.test.ts passed.
  • npm run check passed.
  • Required PR checks are expected to satisfy CI Gate after this branch update and PR body refresh.

Bootstrap Governance

  • Changes are scoped to the linked issue and the active review feedback.
  • Contributor or PR guidance changes are not required for this release workflow change.
  • Auto-merge is currently blocked until PR Fast CI reruns on the pushed branch and review-thread state is cleared.
  • No real secrets, runtime auth, or machine-local env files are committed.

Merge Automation

  • Auto-merge is currently blocked by required checks/review-thread state; re-enable after the refreshed checks pass and the review thread is resolved.

Notes

  • The previous PR body used the older ## Verification / ## Risk shape, which caused Validate PR Description and then CI Gate to fail.

Closes #22

Adds release metadata derivation, source branch validation, optional version/build hooks, release notes file support, and ordering coverage for the reusable release workflow.
@athena-omt athena-omt added area:ai AI, agents, prompts, and model integration work. area:infra Infrastructure, CI, deployment, and operations work. lane:pheidon review:athena risk:medium Moderate implementation or operational risk. state:draft status:needs-review Needs review before merge or closure. labels May 12, 2026
@jmcte jmcte marked this pull request as ready for review May 12, 2026 22:21
@jmcte jmcte requested a review from pheidon as a code owner May 12, 2026 22:21
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ee00d661a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml Outdated
athena-omt
athena-omt previously approved these changes May 12, 2026
Copy link
Copy Markdown

@athena-omt athena-omt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I reviewed the reusable release workflow changes and the test updates. The new metadata derivation, exact SemVer validation, default/maintenance branch ancestry guard, optional version/build hooks, release-notes support, and ordering before floating tag promotion all look consistent with the PR intent.

Local verification on the assigned worker worktree passed:

  • npm test -- tests/reusable-workflows.test.ts --reporter=verbose
  • npm run check — 8 test files / 50 tests passed

The PR is still blocked by the current PR Fast CI/description gate state, but I did not find a source-level blocker in this review.

@jmcte jmcte enabled auto-merge (squash) May 13, 2026 02:01
Reject zero-padded release tags in reusable release workflow metadata derivation and floating-tag promotion. Complete manifest CI customization normalization so the local check gate typechecks with the current CI schema.

Validation: npm test -- tests/reusable-workflows.test.ts; npm run check
Copy link
Copy Markdown

@athena-omt athena-omt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I reviewed the current head 59202965f03a554058a457ee7a555a20deec793c in the required Athena worktree. The release metadata derivation, exact SemVer validation including zero-padded component rejection, branch ancestry guard, optional version/build hooks, release-notes handling, and floating tag promotion ordering look consistent with the issue scope and reusable workflow contract.

Local validation passed:

  • npm test -- tests/reusable-workflows.test.ts --reporter=verbose
  • npm run check — 8 test files / 50 tests passed

Live PR checks also show the refreshed CI Gate/PR Fast checks passing; the remaining BLOCKED state appears review/branch-protection related rather than a source-level blocker.

Copy link
Copy Markdown
Contributor

@pheidon pheidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I reviewed the release workflow orchestration changes at head 5920296, including the stricter SemVer metadata derivation, default/maintenance branch ancestry guard, optional version/build hooks, release-notes handling, release-before-floating-tag ordering, and manifest-driven custom CI/path additions.\n\nLocal validation passed in an isolated worktree:\n- npm test -- tests/reusable-workflows.test.ts --reporter=verbose\n- npm run check — 8 test files / 50 tests passed\n\nLive PR checks show the refreshed required checks passing; I did not find a source-level blocker.

@jmcte jmcte merged commit b096705 into main May 13, 2026
7 of 12 checks passed
@jmcte jmcte deleted the codex/release-workflow-orchestration branch May 13, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai AI, agents, prompts, and model integration work. area:infra Infrastructure, CI, deployment, and operations work. lane:pheidon review:athena risk:medium Moderate implementation or operational risk. state:draft state:waiting-checks status:needs-review Needs review before merge or closure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade reusable release workflow orchestration

3 participants