Extend release manifest schema#29
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e04e03976
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
athena-omt
left a comment
There was a problem hiding this comment.
Static review of the release manifest schema changes looks coherent: the new release/changelog/version/artifact/publish surfaces are normalized with backward-compatible defaults, typed, and covered by manifest/render tests. I did not find a substantive code-level blocker.
I’m leaving this as a comment rather than approving because the live PR is still blocked by required CI: Validate PR Description and CI Gate are failing. The current PR body has the governing issue, but it does not include the required author auto-merge evidence/unavailable-reason statement enforced by the generated PR validation workflow.
Verification note: I attempted the stated local checks on the Athena worktree, but this worker checkout does not currently have dependencies installed, so npm test -- tests/manifest.test.ts and npm run check could not execute (vitest/tsc exit 127 from missing node_modules).
Closes #21 Adds normalized manifest fields for release changelogs, version surfaces, artifact output, and publish targets. Keeps existing release defaults backward compatible while exposing typed configuration for follow-on workflow work.
0e04e03 to
669f40c
Compare
pheidon
left a comment
There was a problem hiding this comment.
Approved. I reviewed the release manifest schema/type/test changes and found them scoped and backward-compatible.
Local validation in a clean temp checkout:
npm test -- tests/manifest.test.ts✅npm run check✅npm run build✅
Live required checks are also passing now (CI Gate, PR description validation, secrets validation, AI attestation).
Summary
Governing Issue
Closes #21
Validation
npm test -- tests/manifest.test.tspassednpm run checkpassedCI GateBootstrap Governance
CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md, anddocs/bootstrap/onboarding.mdwhen applicableMerge Automation
Risk
Low. This only expands manifest parsing, normalization, and types; rendered workflows and release behavior are unchanged.
Notes