Skip to content

Extend release manifest schema#29

Merged
jmcte merged 1 commit into
mainfrom
codex/release-manifest-schema
May 13, 2026
Merged

Extend release manifest schema#29
jmcte merged 1 commit into
mainfrom
codex/release-manifest-schema

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented May 12, 2026

Summary

  • Extend the release manifest schema for changelog, version, artifact, and publish configuration
  • Normalize backward-compatible defaults for new release automation fields
  • Add typed release config surfaces and manifest coverage

Governing Issue

Closes #21

Validation

  • npm test -- tests/manifest.test.ts passed
  • npm run check passed
  • Required PR checks are expected to satisfy CI Gate

Bootstrap Governance

  • Changes are scoped to the linked issue
  • Contributor or PR guidance changes are reflected in CONTRIBUTING.md, .github/PULL_REQUEST_TEMPLATE.md, and docs/bootstrap/onboarding.md when applicable
  • Auto-merge is enabled, or GitHub plan-limit evidence is recorded and the fallback merge-readiness policy applies
  • No real secrets, runtime auth, or machine-local env files are committed

Merge Automation

  • Auto-merge is enabled

Risk

Low. This only expands manifest parsing, normalization, and types; rendered workflows and release behavior are unchanged.

Notes

@athena-omt athena-omt added area:data Data models, persistence, migration, and analytics work. area:infra Infrastructure, CI, deployment, and operations work. lane:pheidon review:athena risk:medium Moderate implementation or operational risk. status:needs-review Needs review before merge or closure. state:draft labels May 12, 2026
@jmcte jmcte marked this pull request as ready for review May 12, 2026 22:21
@jmcte jmcte requested a review from pheidon as a code owner May 12, 2026 22:21
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e04e03976

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/manifest.ts
Copy link
Copy Markdown

@athena-omt athena-omt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review of the release manifest schema changes looks coherent: the new release/changelog/version/artifact/publish surfaces are normalized with backward-compatible defaults, typed, and covered by manifest/render tests. I did not find a substantive code-level blocker.

I’m leaving this as a comment rather than approving because the live PR is still blocked by required CI: Validate PR Description and CI Gate are failing. The current PR body has the governing issue, but it does not include the required author auto-merge evidence/unavailable-reason statement enforced by the generated PR validation workflow.

Verification note: I attempted the stated local checks on the Athena worktree, but this worker checkout does not currently have dependencies installed, so npm test -- tests/manifest.test.ts and npm run check could not execute (vitest/tsc exit 127 from missing node_modules).

@jmcte jmcte enabled auto-merge (squash) May 13, 2026 02:01
Closes #21

Adds normalized manifest fields for release changelogs, version surfaces, artifact output, and publish targets. Keeps existing release defaults backward compatible while exposing typed configuration for follow-on workflow work.
@jmcte jmcte force-pushed the codex/release-manifest-schema branch from 0e04e03 to 669f40c Compare May 13, 2026 19:04
Copy link
Copy Markdown
Contributor

@pheidon pheidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I reviewed the release manifest schema/type/test changes and found them scoped and backward-compatible.

Local validation in a clean temp checkout:

  • npm test -- tests/manifest.test.ts
  • npm run check
  • npm run build

Live required checks are also passing now (CI Gate, PR description validation, secrets validation, AI attestation).

@jmcte jmcte merged commit 3d8ceef into main May 13, 2026
7 of 12 checks passed
@jmcte jmcte deleted the codex/release-manifest-schema branch May 13, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data Data models, persistence, migration, and analytics work. area:infra Infrastructure, CI, deployment, and operations work. lane:pheidon review:athena risk:medium Moderate implementation or operational risk. state:draft state:waiting-checks status:needs-review Needs review before merge or closure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend manifest release automation schema

3 participants