Skip to content

Pipe#376

Draft
james58899 wants to merge 23 commits intomasterfrom
pipe
Draft

Pipe#376
james58899 wants to merge 23 commits intomasterfrom
pipe

Conversation

@james58899
Copy link
Copy Markdown
Member

@james58899 james58899 commented Apr 15, 2021

外觀

  • 本體
  • 連接
  • IO
  • 傳輸中物品

功能

  • 抽取
  • 輸出
  • 儲存
  • 傳輸

@james58899 james58899 added status: wip This pr is working in progess system: block type: feature New feature labels Apr 15, 2021
@james58899 james58899 self-assigned this Apr 15, 2021
# Conflicts:
#	src/main/java/one/oktw/galaxy/mixin/tweak/MixinCustomBlockEntity_BarrierBlock.java
#	src/main/kotlin/one/oktw/galaxy/block/entity/ModelCustomBlockEntity.kt
@james58899 james58899 marked this pull request as ready for review July 8, 2021 14:08
@james58899 james58899 added status: needs review This pr needs review status: needs testing This pr needs testing and removed status: wip This pr is working in progess labels Jul 8, 2021
Copy link
Copy Markdown
Member

@jimchen5209 jimchen5209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

將是 nbt 但變數名稱是 tag 的變數統一成 nbt

Comment thread src/main/kotlin/one/oktw/galaxy/block/entity/ModelCustomBlockEntity.kt Outdated
Comment thread src/main/kotlin/one/oktw/galaxy/block/entity/PipeBlockEntity.kt Outdated
Comment thread src/main/kotlin/one/oktw/galaxy/block/pipe/ItemTransferPacket.kt Outdated
Comment thread src/main/kotlin/one/oktw/galaxy/util/CompoundTagExt.kt Outdated
Comment thread src/main/kotlin/one/oktw/galaxy/block/pipe/ItemTransferPacket.kt Outdated
Copy link
Copy Markdown
Member

@jimchen5209 jimchen5209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Passed

Looks good

@jimchen5209 jimchen5209 removed the status: needs review This pr needs review label Jul 8, 2021
@james58899 james58899 marked this pull request as draft July 18, 2021 06:03
@jimchen5209 jimchen5209 added status: wip This pr is working in progess and removed status: needs testing This pr needs testing labels Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: wip This pr is working in progess system: block type: feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants