fix(HistoryMemo): Segmentation delete wasn't remembered by wayfarer3130 · Pull Request #5775 · OHIF/Viewers

wayfarer3130 · 2026-02-03T22:37:03Z

Context

The delete of segment index wasn't being remembered for the history.
This requires cornerstonejs/cornerstone3D#2593 to be linked to work.

Note: Undo of a delete restores the segment index, and redo of a delete removes it.

Changes & Results

Adds a history memo for delete/restore of the segment index.

Does not add support for remembering other changes on segment index like rename.

Testing

Test for segment index for labelmap and contour indexes

Create segmentation (not undo create segmentation is NOT supported)
Draw a segment
Create a new segment index
Draw a segment
Create a new segment index
Draw a segment

Delete segment #1, then #2 then #3

Undo 6 times to remove all segment indices on screen
Segment indexes should appear as the 3 deletes are undone, AND the segment data should reappear.
Segments drawn should disappear as remaining 3 deletes are done.
NOTE: Segment index add is not recorded, so undoing it does nothing

Redo 6 times
Segments drawn should reappear in first 3 redo
Segments drawn should disappear as redo of next 3 deletes. This should remove the segment index from the table.

Test the whole kittencaboodle with a contours after doing labelmaps.
Maybe test undo/redo of multi frames of segmentations - this should delete all the single segment index on all frames at once.

Checklist

PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[] OS:
[] Node version:
[] Browser:

netlify · 2026-02-03T22:37:13Z

✅ Deploy Preview for ohif-dev ready!

Name	Link
🔨 Latest commit	`2bac9fd`
🔍 Latest deploy log	https://app.netlify.com/projects/ohif-dev/deploys/6983be97a126160008f8752f
😎 Deploy Preview	https://deploy-preview-5775--ohif-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

cypress · 2026-02-04T15:54:33Z

Viewers Run #5908

Run Properties: Passed #5908 • 2bac9fdb03: fix: Use newer dcmjs version and delete segmentation with history cs3d

Project	`Viewers`
Branch Review	`fix/OHIF-2461-OHIF-2460-segmentation-history-fix`
Run status	`Passed #5908`
Run duration	`02m 17s`
Commit	`2bac9fdb03: fix: Use newer dcmjs version and delete segmentation with history cs3d`
Committer	`Bill Wallace`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`37`
View all changes introduced in this branch ↗︎

jbocce · 2026-02-04T16:57:34Z

Testing Notes:

I was not able to undo the creation of a spline contour; that is once created clicking undo does not (eventually) remove the spline contour. Furthermore after several clicks of undo, several clicks of undo adds somewhat of an identical spline, sort of duplicating what is there

ScreenHunter.Feb.04.11.37.mp4

undo of Duplicate Contour does not work or is not implemented yet

…2460-segmentation-history-fix

wayfarer3130 · 2026-02-04T22:36:29Z

@aimee-ferreira - the test build for this has the remaining issues for OHIF 3.12 RC2

OHIF-2461: [Bug] Toast message on redo of contours
OHIF-2460: [Bug] Redo action brings back labelmap on image but not in panel
OHIF-2466: [Bug] OHIF 3.12 release candidate is creating invalid DICOM seg objects
OHIF-2456: [Bug] Saving rectangles with HU as pixel units saves unit as 'mm'

I have tested all 4 issues, plus Joe's navigation issue in combination with these. The only remaining bugs I've found are:

[Bug] Undo/redo of contours with holes throws exceptions #5780
[Bug] Can't undo/redo segmentation colour, segment index add, relabel, label segment overall #5781

jbocce · 2026-02-05T02:09:49Z

bun.lock

@@ -1,5 +1,6 @@
 {
  "lockfileVersion": 1,
+  "configVersion": 0,


What version of bun are you running? Mine does not add this in to the lock file.

1.3.8 is what I run. I don't think it is a big deal to have this added unless it causes problems in earlier versions. The bun.lock is not hte official lockfile, but is for faster dev testing.

jbocce · 2026-02-05T02:15:01Z

extensions/cornerstone/src/utils/updateSegmentationStats.ts

  Object.entries(stats).forEach(([segmentIndex, segmentStats]) => {
    const index = parseInt(segmentIndex);

+    if (!updatedSegmentation.segments[index]) {


Perhaps safest to do if (!updatedSegmentation?.segments?.[index]) {?

jbocce · 2026-02-05T02:33:42Z

extensions/cornerstone/src/services/SegmentationService/SegmentationService.ts

   */
-  public removeSegment(segmentationId: string, segmentIndex: number): void {
-    cstSegmentation.removeSegment(segmentationId, segmentIndex);
+  public removeSegment(


So why doesn't SegmentationService.addSegment memo/record its actions? Is it worth mentioning somewhere in the code comments?

Because I only implemented the delete operation as I was trying to minimize how many changes we have at this point. If we want, we can go ahead and fix all the remaining issues we've seen, but I specifically created a secondary issue to track things like the addSegment not adding the memo.

Ok. Then maybe add a ToDo or something?

jbocce

Just some minor comments. See my testing notes #5775 (comment). I added @aimee-ferreira as a reviewer for testing purposes.

wayfarer3130 · 2026-02-05T15:27:44Z

Added cornerstonejs/cornerstone3D#2599 to describe Joe's issue.

aimee-ferreira

Verification has passed.

Tested undo/redo with both label map and contours + mixture - all deleted segments are added back to both the image and panel successfully
Tested when segment is hidden, delete and undo returns the segment in the hidden state, the segment can be re-displayed successfully

jbocce

Approving even though there are pending comments.

fix(HistoryMemo): Segmentation delete wasn't remembered

cf46fed

Temporary add of package.json linking

af8d5f6

wayfarer3130 added 2 commits February 4, 2026 16:47

Merge remote-tracking branch 'origin/master' into fix/OHIF-2461-OHIF-…

348d4ea

…2460-segmentation-history-fix

fix: Use newer dcmjs version and delete segmentation with history cs3d

2bac9fd

wayfarer3130 requested a review from jbocce February 4, 2026 22:22

jbocce reviewed Feb 5, 2026

View reviewed changes

jbocce requested a review from aimee-ferreira February 5, 2026 02:34

jbocce requested changes Feb 5, 2026

View reviewed changes

aimee-ferreira approved these changes Feb 5, 2026

View reviewed changes

jbocce approved these changes Feb 5, 2026

View reviewed changes

wayfarer3130 merged commit 48f2f6f into master Feb 5, 2026
10 of 11 checks passed

wayfarer3130 deleted the fix/OHIF-2461-OHIF-2460-segmentation-history-fix branch February 5, 2026 17:27

Uh oh!

Conversation

wayfarer3130 commented Feb 3, 2026

Context

Changes & Results

Testing

Checklist

PR

Code

Public Documentation Updates

Tested Environment

Uh oh!

netlify bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for ohif-dev ready!

Uh oh!

cypress bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Viewers Run #5908

Uh oh!

jbocce commented Feb 4, 2026

Uh oh!

wayfarer3130 commented Feb 4, 2026

Uh oh!

jbocce Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

wayfarer3130 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

jbocce Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

jbocce Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

wayfarer3130 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

jbocce Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

jbocce left a comment

Choose a reason for hiding this comment

Uh oh!

wayfarer3130 commented Feb 5, 2026

Uh oh!

aimee-ferreira left a comment

Choose a reason for hiding this comment

Uh oh!

jbocce left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Feb 3, 2026 •

edited

Loading

cypress bot commented Feb 4, 2026 •

edited

Loading