adding phevaluator module functionality and colDefs for all reactables per new result model spec#209
Open
adding phevaluator module functionality and colDefs for all reactables per new result model spec#209
Conversation
…) function, ensuring plot will work if no trellises are selected
CG: when cohort inclusion and attrition results are not present, show proper and clean shiny message to the user Incidence: All standard plots updated
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 78.56% 78.49% -0.08%
==========================================
Files 72 72
Lines 17803 17828 +25
==========================================
+ Hits 13987 13994 +7
- Misses 3816 3834 +18 ☔ View full report in Codecov by Sentry. |
…hinyModules into revert-test" This reverts commit 8d1b9b5, reversing changes made to 17a2002.
This reverts commit 17a2002.
Collaborator
|
@nhall6 is this pull request still needed? |
Collaborator
Author
Yes I believe so. But we can merge into develop instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.