Conversation
added 30 commits
May 3, 2022 17:58
…nd file paths match
loadAndromeda needs to assign FileSystemDatasets to an andromeda object. The andromeda assignment method must treat FileSystemDataset object as a potential reference to another andromeda table so it makes a copy. When loading we want to disable this behavior by temorarily removing the andromeda class.
…h value type separately. Add test for Andromeda table overwrites.
…meda to list during restore.
Codecov Report
@@ Coverage Diff @@
## develop #40 +/- ##
===========================================
- Coverage 89.21% 83.93% -5.29%
===========================================
Files 4 3 -1
Lines 371 249 -122
===========================================
- Hits 331 209 -122
Misses 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…normal list assignment. Fixes #41
…omeda objects fails.
Collaborator
Author
|
Before this release each Hades maintainer that depends on Andromeda will need to make sure their package works with both the old and new versions. The biggest change is probably how to get rowcounts. An example is OHDSI/FeatureExtraction#179. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses