Draft
Conversation
darksylinc
added a commit
that referenced
this pull request
Feb 10, 2022
darksylinc
added a commit
that referenced
this pull request
Feb 10, 2022
The struct ScheduledTasks is protected, hence functions that use it as arguments can never be used. Additionally, those functions made no sense to be called externally
Member
|
I fixed all the |
Contributor
Author
|
Thanks. You probably missed protected Any comments about idea to add Python API via SWIG? |
3904aa1 to
da6dbf9
Compare
76d820e to
03fbfb6
Compare
WIP: * working but incomplete * need some cleanup (e.g. move testRun.py to samples)
2ee1c83 to
8b3ddcc
Compare
49c451d to
84c07a0
Compare
a3c7671 to
67f9fdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is proposition to add Python API to Ogre-next generated by SWIG.
The SWIG as Ogre Component approach is inspired by Python API from Ogre 1.x. This is updated (and reworked) version of my PR for 2.1 from bitbucket (abandoned with 2.1 and bitbucket).
The main question is if we want the Python API in Ogre itself or maybe as separated project (it use only headers and linking to OgreMain.so)?
API can be used to manipulate Ogre objects from python script system in C++ (where most of the Ogre related stuff is made in C++, main use case for me) or to init and use Ogre from pure Python (see testRun.py example).
Currently API is working, but incomplete and need some cleanup too (e.g. move testRun.py to samples and use Media from Ogre in it).
While creating and testing API I found some problem in Ogre itself (see FIXME notes in Ogre.i - mostly protected types used in public interface and missing reference by declared but not define functions), I can create PR to fix this if you want.
I use HLMS init code from samples as Python API element (see initHLMS.i), maybe Ogre should provide such helper function?