feat: add links to navbar #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstimberg
reviewed
Jun 18, 2025
Collaborator
mstimberg
left a comment
mstimberg
left a comment
There was a problem hiding this comment.
I just tried it out and all looks good, but for consistency we should probably open all external links in a new tab – right now this is the case for the main links in the title bar, but not for the links in Resources and in the "Using this resource" text.
Collaborator
|
Merging this now |
Contributor
Author
|
Sorry Marcel, am stuck in a bit of traffic. Should be there in 5.
…--
Thanks,
Ankur
(Sent from mobile device)
On Wed, 18 Jun 2025, 13:20 Marcel Stimberg, ***@***.***> wrote:
***@***.**** commented on this pull request.
I just tried it out and all looks good, but for consistency we should
probably open all external links in a new tab – right now this is the case
for the main links in the title bar, but not for the links in Resources and
in the "Using this resource" text.
—
Reply to this email directly, view it on GitHub
<#92 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZBL75MPTQ4WTEIHND2WD3EFKRPAVCNFSM6AAAAAB7S3OZNCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZYHE4DENBXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.