-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[18.0][ADD] web_tree_column_keyboard_resize #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][ADD] web_tree_column_keyboard_resize #3412
Conversation
legalsylvain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on chromium and firefox. Don't reach to resize column.
Step to reproduce on runboat;
- Invoicing > new Customer invoice > click on a new line.
- click on Shift left / right arrow.
did I missed something ?
thanks !
d4be12a to
6ec372f
Compare
|
Hello @legalsylvain, thanks for checking this out!! Actually, I made a mistake in the documentation of the module, my bad (I already fixed it). The shortcuts are actually the following:
I've recorded a video to show you how it's supposed to work (testing runboat in Firefox by the way). web_tree_column_keyboard_resize.mp4 |
legalsylvain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functional review. no code review. works like a charm.
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 071ca09. Thanks a lot for contributing to OCA. ❤️ |
No description provided.