Skip to content

[19.0][MIG] web_chatter_position: Migration to 19.0 #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BhaveshHeliconia wants to merge 20 commits into
base: 19.0
Choose a base branch
from
Open

[19.0][MIG] web_chatter_position: Migration to 19.0 #3325

BhaveshHeliconia wants to merge 20 commits into from
+1,232 −0

Conversation

@BhaveshHeliconia
Copy link
Contributor

@BhaveshHeliconia BhaveshHeliconia commented Oct 17, 2025

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Oct 17, 2025
Open
43 tasks
DucTruongKomit
DucTruongKomit reviewed Nov 7, 2025
View reviewed changes
Copy link

@DucTruongKomit DucTruongKomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, no application error and any wrong so far.
Could you help to solve pre-commit and squash commit, please? @BhaveshHeliconia

@quoc-pn
Copy link
Member

quoc-pn commented Jan 20, 2026

@BhaveshHeliconia I can not find the runboat instance to test, could you please help check? Thank you!

JuMiSanAr and others added 16 commits January 20, 2026 13:41
@JuMiSanAr @BhaveshHeliconia
web_chatter_position: create module
c4eed73
@ivantodorovich @BhaveshHeliconia
[MIG] web_chatter_position: Migration to 16.0
cab68c4
@tate11 @BhaveshHeliconia
Added translation using Weblate (Turkish)
692b938
@remi-filament @BhaveshHeliconia
Added translation using Weblate (French)
f860f88
@badbole @BhaveshHeliconia
Added translation using Weblate (Croatian)
4cdded1
@kikopeiro @BhaveshHeliconia
Added translation using Weblate (Spanish)
306fdb9
@BT-jmontero @BhaveshHeliconia
Fixed JS assuming "o_form_sheet_bg" is always found
8299cd7
@Jan-Onestein @BhaveshHeliconia
Added translation using Weblate (Dutch)
8f58349
@adrianojprado @BhaveshHeliconia
Added translation using Weblate (Portuguese (Brazil))
c85d20e
@daiduongnguyen-odoo @BhaveshHeliconia
[FIX] web_chatter_position: special case of sided chatter pos in mass
4b989e8 
mailing module
- Because the chatter in mass mailing form view lie under a notebook
tab, if user choose sided chatter, it will disappear
@pere-aquarian @BhaveshHeliconia
Added translation using Weblate (Catalan)
90340ad
@mymage @BhaveshHeliconia
Added translation using Weblate (Italian)
cf926ba
@jappi00 @BhaveshHeliconia
Added translation using Weblate (German)
656a5a0
@ptsuva @BhaveshHeliconia
[IMP] web_chatter_position: pre-commit auto fixes
4db3787
@ptsuva @BhaveshHeliconia
[MIG] web_chatter_position: Migration to 17.0
3895ac4 
[IMP] web_chatter_position: improve function compile

web_chatter_position: propose myself as maintainer
@ellbristow @BhaveshHeliconia
[IMP] web_chatter_position: pre-commit auto fixes
8541d9f
@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-web_chatter_position branch from 37130d2 to 7b41597 Compare January 20, 2026 08:11
@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Jan 20, 2026

@quoc-pn : The Runboat instance is now up and running. You can test it now. Thanks!

@quoc-pn
Copy link
Member

quoc-pn commented Jan 20, 2026

Hi @BhaveshHeliconia

The chatter width in “Sided” position is too large and reduces usable space when displaying large content.

I expect the width to be the same as the "Responsive" position.

image

@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-web_chatter_position branch 2 times, most recently from 4614577 to cc5e080 Compare January 20, 2026 09:28
@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Jan 20, 2026

@quoc-pn : Good catch. I’ve fixed the issue and aligned the width with the “Responsive” position. Please check again. Thanks!

quoc-pn
quoc-pn approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@quoc-pn quoc-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tested, LGTM!

@quoc-pn
Copy link
Member

quoc-pn commented Jan 20, 2026 •
edited
Loading

@BhaveshHeliconia

There are some commit made by Bots, please follow steps in the link below to clear them. Thank you!

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#:~:text=Check%20https%3A//github.com/OCA/maintainer%2Dtools/wiki/Merge%2Dcommits%2Din%2Dpull%2Drequests%20for%20a%20procedure%20for%20reducing%20commits%20from%20%22OCA%20Transbot...%22.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-web_chatter_position branch from cc5e080 to b921fec Compare January 20, 2026 10:31
@BhaveshHeliconia
Copy link
Contributor Author

BhaveshHeliconia commented Jan 20, 2026

@BhaveshHeliconia

There are some commit made by Bots, please follow steps in the link below to clear them. Thank you!

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#:~:text=Check%20https%3A//github.com/OCA/maintainer%2Dtools/wiki/Merge%2Dcommits%2Din%2Dpull%2Drequests%20for%20a%20procedure%20for%20reducing%20commits%20from%20%22OCA%20Transbot...%22.

@quoc-pn Done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@DucTruongKomit DucTruongKomit DucTruongKomit left review comments

@quoc-pn quoc-pn quoc-pn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.