Skip to content

[16.0][FIX] spreadsheet_oca: add raiseError function to SpreadsheetRenderer and fix pre-commit complaints #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Dec 6, 2025
Merged

[16.0][FIX] spreadsheet_oca: add raiseError function to SpreadsheetRenderer and fix pre-commit complaints #87

OCA-git-bot merged 1 commit into from
Dec 6, 2025

Conversation

@rrebollo
Copy link

@rrebollo rrebollo commented Nov 30, 2025

Fixes #85 and some pre-commit complaints

@BinhexTeam

@rrebollo rrebollo marked this pull request as ready for review November 30, 2025 10:32
@rrebollo
Copy link
Author

rrebollo commented Nov 30, 2025

@chrisandrewmann could you review this?

@chrisandrewmann
Copy link
Contributor

chrisandrewmann commented Nov 30, 2025 •
edited
Loading

@chrisandrewmann could you review this?

Thanks, will try and look on Monday. In the meantime it looks like you forgot to mention the version number in the title?

@rvalyi rvalyi changed the title [FIX] spreadsheet_oca: add raiseError function to SpreadsheetRenderer and fix pre-commit complaints [16.0][FIX] spreadsheet_oca: add raiseError function to SpreadsheetRenderer and fix pre-commit complaints Nov 30, 2025
chrisandrewmann
chrisandrewmann approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@chrisandrewmann chrisandrewmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, brief test of raising error by merging cells and trying to apply a filter correctly causes error dialog to be shown as intended. @rrebollo

@rrebollo rrebollo force-pushed the 16.0-fix-spreadsheet_oca-missing-env-raiseError-function branch from 3ccef6e to f81458d Compare December 5, 2025 16:51
@rrebollo
Copy link
Author

rrebollo commented Dec 5, 2025

@etobella Could you also review this? It's the backport of #86.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 5, 2025
@rrebollo rrebollo force-pushed the 16.0-fix-spreadsheet_oca-missing-env-raiseError-function branch from 8ed521b to a98ceb4 Compare December 5, 2025 21:29
pedrobaeza
pedrobaeza approved these changes Dec 6, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As being the same as 17. Only 18 left.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 6, 2025

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-87-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 6, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit cfc7d67 into OCA:16.0 Dec 6, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 6, 2025

Congratulations, your PR was merged at 2914380. Thanks a lot for contributing to OCA. ❤️

@rrebollo
Copy link
Author

rrebollo commented Dec 8, 2025

@pedrobaeza according to @chrisandrewmann tests 18.0 is not being affected by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@etobella etobella etobella approved these changes

+1 more reviewer

@chrisandrewmann chrisandrewmann chrisandrewmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rrebollo @chrisandrewmann @OCA-git-bot @pedrobaeza @etobella