[19.0][MIG] procurement_purchase_sale_no_grouping#3111
Open
Firas-Bessaad wants to merge 14 commits into
Open
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: purchase-workflow-17.0/purchase-workflow-17.0-procurement_purchase_sale_no_grouping Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-procurement_purchase_sale_no_grouping/it/
Currently translated at 100.0% (2 of 2 strings) Translation: purchase-workflow-18.0/purchase-workflow-18.0-procurement_purchase_sale_no_grouping Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-procurement_purchase_sale_no_grouping/sl/
- Bump manifest version to 19.0.1.0.0. - Retarget the search override from purchase.order to purchase.order.line: in 19.0 sale_purchase looks up an existing RFQ via purchase.order.line.search() (_purchase_service_match_purchase_order) instead of purchase.order.search(); the search_purchase_no_grouping context must therefore neutralize the line-level search so that the "No order grouping" option keeps creating one RFQ per sale line. - Adapt test to the renamed sale.order.line field product_uom -> product_uom_id.
OCA-git-bot
added
series:19.0
mod:procurement_purchase_sale_no_grouping
Author
|
@carlosdauden as the original author of this module, would you mind reviewing this 19.0 migration when you have a moment? The notable change is that the search override moved from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
procurement_purchase_sale_no_groupingto 19.0.Depends on
procurement_purchase_no_grouping, already migrated in #3009.Functional change for 19.0
In 18.0,
sale_purchaselooked up an existing RFQ to reuse throughpurchase.order.search(). In 19.0 it does so throughpurchase.order.line.search()(seeSaleOrderLine._purchase_service_match_purchase_order).The
search_purchase_no_groupingcontext override has therefore been movedfrom
purchase.ordertopurchase.order.line, so that returning an emptyrecordset still forces a brand new purchase order to be created. This keeps the
"No order grouping" behaviour working (one RFQ per sale order line).
SaleOrderLine._purchase_service_createis unchanged.Tests
product_uom->product_uom_id)."No order grouping" creates one RFQ per line, other grouping modes group as
before.
Connected to #2833