[18.0][MIG] purchase_work_acceptance_evaluation: Migration to 18.0#3100
Open
ROBBYHOOD9 wants to merge 29 commits into
Open
[18.0][MIG] purchase_work_acceptance_evaluation: Migration to 18.0#3100ROBBYHOOD9 wants to merge 29 commits into
ROBBYHOOD9 wants to merge 29 commits into
Conversation
OCA-git-bot
added
series:18.0
mod:purchase_work_acceptance_evaluation
ROBBYHOOD9
force-pushed
the
18.0-mig-purchase_work_acceptance_evaluation
branch
from
201f45b to
a943246
Compare
4 tasks
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Consider using BaseCommon instead of TransactionCase. In this case, there’s no need to redefine cls.env with tracking_disable=True.
ROBBYHOOD9
force-pushed
the
18.0-mig-purchase_work_acceptance_evaluation
branch
from
a943246 to
4319e3c
Compare
Contributor
Author
|
Thanks for the suggestion. I've updated the test to use |
BhaveshHeliconia
approved these changes
Jun 15, 2026
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Code review LGTM!
Contributor
|
This PR has the |
1 similar comment
Contributor
|
This PR has the |
…hen no state required
Currently translated at 100.0% (37 of 37 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_work_acceptance_evaluation Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_work_acceptance_evaluation/es/
Currently translated at 100.0% (37 of 37 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_work_acceptance_evaluation Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_work_acceptance_evaluation/it/
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ROBBYHOOD9
force-pushed
the
18.0-mig-purchase_work_acceptance_evaluation
branch
from
4319e3c to
fa05c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration
purchase_work_acceptance_evaluationfrom 15.0 to 18.01. Module Version
Updated the module version to align with Odoo 18.
"version": "16.0.1.0.0",=>"version": "18.0.1.0.0",2. Python Code Updates
Updated Python code to comply with Odoo 18 requirements and Ruff recommendations.
user_has_groups(...)withself.env.user.has_group(...).ltorto avoid Ruff E741 (ambiguous variable name).apito imports inwork_acceptance_evaluation.py.name_get()with_compute_display_name()and added@api.depends("name", "score").%string formatting with f-strings to comply with Ruff UP031.3. View Migration
Updated XML views to follow the Odoo 17/18 architecture.
<tree>with<list>.<setting>structure and//block[@name='...']xpath.4. Report Updates
Updated report views for Odoo 18 compatibility.
<tree>with<list>.5. Test Updates
Updated tests to follow newer Odoo conventions.
setUp()withsetUpClass().tracking_disable=True.display_nameinstead ofname_get().