Skip to content

[18.0][MIG] purchase_work_acceptance_late_fine: Migration to version 18.0#3098

Open
ROBBYHOOD9 wants to merge 23 commits into
OCA:18.0from
ecosoft-odoo:18.0-mig-purchase_work_acceptance_late_fines
Open

[18.0][MIG] purchase_work_acceptance_late_fine: Migration to version 18.0#3098
ROBBYHOOD9 wants to merge 23 commits into
OCA:18.0from
ecosoft-odoo:18.0-mig-purchase_work_acceptance_late_fines

Conversation

@ROBBYHOOD9

@ROBBYHOOD9 ROBBYHOOD9 commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Migration purchase_work_acceptance_late_fine from 15.0 to 18.0

1. Module Version

Updated the module version to align with Odoo 18.
"version": "15.0.1.1.0" → "version": "18.0.1.0.0"

2. Model Updates

Updated Python code to comply with Odoo 18 requirements.

  • Removed states= from 3 fields.
  • Changed action view_mode from tree to list.

3. View Migration

Updated XML views to follow the Odoo 17/18 architecture.

  • views/work_acceptance_views.xml Replaced 3 attrs expressions with inline expressions.
  • views/account_move_views.xml Replaced 1 attrs expression with an inline expression.
  • views/res_config_settings_views.xml Changed xpath from //div[@name=...] to //block[@name=...].
  • Migrated the settings layout to the new <setting> structure.
  • Replaced attrs expressions with inline expressions.

4. Test Updates

Updated tests to follow newer Odoo conventions.

  • Replaced deprecated user_type_id with account_type.
  • Fixed SQL query parameters that were passed in the wrong order.
  • Added tracking_disable=True to prevent chatter tracking during test execution.

@OCA-git-bot OCA-git-bot added series:18.0 mod:purchase_work_acceptance_late_fines Module purchase_work_acceptance_late_fines labels Jun 10, 2026
@ROBBYHOOD9 ROBBYHOOD9 force-pushed the 18.0-mig-purchase_work_acceptance_late_fines branch from 2532323 to d820980 Compare June 10, 2026 11:18
@ROBBYHOOD9 ROBBYHOOD9 mentioned this pull request Jun 11, 2026
Open
4 tasks
BhaveshHeliconia
BhaveshHeliconia reviewed Jun 12, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using BaseCommon instead of TransactionCase. In this case, there’s no need to redefine cls.env with tracking_disable=True.

Comment thread purchase_work_acceptance_late_fines/tests/test_work_acceptance_late_fine.py Outdated
Comment thread purchase_work_acceptance_late_fines/tests/test_work_acceptance_late_fine.py Outdated
@ROBBYHOOD9 ROBBYHOOD9 force-pushed the 18.0-mig-purchase_work_acceptance_late_fines branch from d820980 to 7cd6e31 Compare June 12, 2026 09:30
@ROBBYHOOD9

ROBBYHOOD9 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@BhaveshHeliconia

Thanks for the suggestion. I've updated the test to use BaseCommon, removed the unnecessary tracking_disable=True override, and fixed the setup_main_company currency configuration to ensure the test environment is initialized correctly.

BhaveshHeliconia
BhaveshHeliconia approved these changes Jun 15, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

Pani-k-folk
Pani-k-folk approved these changes Jun 24, 2026
View reviewed changes

@Pani-k-folk Pani-k-folk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

@OCA-git-bot

OCA-git-bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

5 similar comments
@OCA-git-bot

OCA-git-bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot

OCA-git-bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot

OCA-git-bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot

OCA-git-bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot

OCA-git-bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ps-tubtim and others added 10 commits June 24, 2026 16:41
@ps-tubtim @ROBBYHOOD9
[FIX] purchase_work_acceptance_late_fines: fix _onchange_late_days
bcc1d31
@ROBBYHOOD9
[UPD] Update purchase_work_acceptance_late_fines.pot
715934a
@OCA-git-bot @ROBBYHOOD9
purchase_work_acceptance_late_fines 15.0.1.1.0
f9f6f3b
@OCA-git-bot @ROBBYHOOD9
[UPD] README.rst
6d29493
@Ivorra78 @ROBBYHOOD9
Added translation using Weblate (Spanish)
9c6e767
@Ivorra78 @ROBBYHOOD9
Translated using Weblate (Spanish)
daecb06 
Currently translated at 100.0% (44 of 44 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_work_acceptance_late_fines
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_work_acceptance_late_fines/es/
@pcastelovigo @ROBBYHOOD9
Added translation using Weblate (Galician)
378e130
@pcastelovigo @ROBBYHOOD9
Translated using Weblate (Galician)
c9b071c 
Currently translated at 100.0% (44 of 44 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_work_acceptance_late_fines
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_work_acceptance_late_fines/gl/
@ROBBYHOOD9
[IMP] purchase_work_acceptance_late_fines: pre-commit auto fixes
bbf609f
@ROBBYHOOD9
[18.0][MIG] purchase_work_acceptance_late_fines: Migration to 18.0
12c7c0e
@ROBBYHOOD9 ROBBYHOOD9 force-pushed the 18.0-mig-purchase_work_acceptance_late_fines branch from 7cd6e31 to 12c7c0e Compare June 24, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Pani-k-folk Pani-k-folk Pani-k-folk approved these changes
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:purchase_work_acceptance_late_fines Module purchase_work_acceptance_late_fines ready to merge series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.