[18.0][ADD] project_sale_link

[mathben]

• copying project_purchase_link and rename purchase to sale

[flotho]

Hi,
LGTM
sucessfully tested on runboat

[mathben]

ping @carlos-lopez-tecnativa @pedrobaeza
Thanks you!

[pedrobaeza]

Copy from where? Did the previous authors sign the OCA CLA? You should also respect the whole commit history, and rename it from the beginning with:

git filter-branch --tree-filter 'if [ -d <old_module_name> ]; then mv <old_module_name> <new_module_name>; fi' HEAD
git rebase origin/18.0

[mathben]

Copy from where?

This repository : https://github.com/OCA/project/tree/18.0/project_purchase_link

Did the previous authors sign the OCA CLA?

I didn't check : https://github.com/OCA/project/blob/18.0/project_purchase_link/readme/CONTRIBUTORS.md

You should also respect the whole commit history, and rename it from the beginning with

The history : https://github.com/OCA/project/commits/18.0/project_purchase_link
It's a little hard to copy, the history is already in this repository.
I run your command to test and nothing done (except recommit all history).
Thanks @pedrobaeza

[pedrobaeza]

OK, then it's not a copy, but it's a "brother" module inspired from the other. Isn't this what sale_project do? In any case, it's OK to add it and just mention in the CREDITS.md file that this comes from project_purchase_link.

[leemannd]

Hello, we formerly already had a similar module in 13.0 -> #940

[alexey-pelykh]

The compute methods _compute_sale_info and _compute_sale_invoice_info multiply price_subtotal * count which double-counts amounts since read_group already returns the sum -- the purchase sibling correctly just sums group["price_subtotal"]. Also, _domain_sale_invoice does not filter on move_type, so the invoice count mixes vendor bills with customer invoices. Finally, per @pedrobaeza's suggestion, CREDITS.md should mention this module is inspired by project_purchase_link.

[mathben]

@alexey-pelykh thanks for your review, I apply your suggestion. I change type of sale_line_total from integer to monetary.
Because I copied the module project_purchase_link, we have the same bug in this module too.
https://github.com/OCA/project/blob/18.0/project_purchase_link/models/project_project.py#L121

@pedrobaeza CREDITS.md added

@leemannd is really similar with module version 13, I didn't test.

Thanks