[19.0][MIG] project_task_name_with_id: Migration to 19.0#1579
[19.0][MIG] project_task_name_with_id: Migration to 19.0#1579OCA-git-bot merged 17 commits intoOCA:19.0from
Conversation
AungKoKoLin1997
force-pushed
the
19.0-mig-project_task_name_with_id
branch
from
26c43ec to
4444609
Compare
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
Code review and functional test. LGTM.
|
/ocabot migration project_task_name_with_id |
|
|
||
| - Yoshi Tashiro | ||
|
|
||
| - Miquel Pascual <mpascual@apsl.net> |
There was a problem hiding this comment.
I think @AungKoKoLin1997 included my name here as the module was done by me initially, and he just followed the order of contributions. We will fix it if that's an issue.
Currently translated at 100.0% (1 of 1 strings) Translation: project-16.0/project-16.0-project_task_name_with_id Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_name_with_id/it/
AungKoKoLin1997
force-pushed
the
19.0-mig-project_task_name_with_id
branch
from
4444609 to
0c22bb2
Compare
nobuQuartile
left a comment
nobuQuartile
left a comment
There was a problem hiding this comment.
Code review and functional test: LGTM
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for the migration, @yostashiro.
Compared to the 18.0 version: the expression.AND to Domain.AND migration looks correct, and the if not task.id: continue guard in _compute_display_name is a good defensive addition for NewId records. The search view now correctly targets project.view_task_search_form_project_base instead of the old sharing search view -- makes sense given the 19.0 view restructuring.
One minor note: the DESCRIPTION.md still references name_get() which was removed in Odoo 17 in favor of _compute_display_name. Not blocking, but worth a follow-up to keep the docs accurate.
CI green on both OCB and Odoo, pre-commit passes. LGTM.
| @@ -0,0 +1,7 @@ | |||
| This module extends the name_search() and name_get() methods of the | |||
There was a problem hiding this comment.
Nit: this still mentions name_get() which no longer exists since Odoo 17 -- the module now overrides _compute_display_name. Consider updating the wording in a follow-up.
There was a problem hiding this comment.
I updated.
Thank you.
AungKoKoLin1997
force-pushed
the
19.0-mig-project_task_name_with_id
branch
from
0c22bb2 to
f59c56d
Compare
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at b7b3246. Thanks a lot for contributing to OCA. ❤️ |
10 participants
@qrtl QT5667