[19.0][MIG] project_parent by norlinhenrik · Pull Request #1576 · OCA/project

norlinhenrik · 2025-10-05T15:16:26Z

No description provided.

…iews.xml, remove post_install file

…id on action

Currently translated at 100.0% (5 of 5 strings) Translation: project-13.0/project-13.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_parent/es/

Currently translated at 80.0% (4 of 5 strings) Translation: project-16.0/project-16.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent/pt_BR/

Currently translated at 100.0% (6 of 6 strings) Translation: project-16.0/project-16.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent/es/

Currently translated at 83.3% (5 of 6 strings) Translation: project-16.0/project-16.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent/pt_BR/

Currently translated at 100.0% (6 of 6 strings) Translation: project-17.0/project-17.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-17-0/project-17-0-project_parent/it/

Currently translated at 100.0% (6 of 6 strings) Translation: project-18.0/project-18.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-18-0/project-18-0-project_parent/pt/

rousseldenis · 2025-10-12T13:25:41Z

/ocabot migration project_parent

rousseldenis · 2025-10-12T13:28:05Z

@@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!-- © 2017-2019 Elico Corp (https://www.elico-corp.com).
+License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html). -->


Could you clarify license here ?

# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html). "license": "LGPL-3",

I think that is pretty clear.

This seems fine to me

@norlinhenrik Ok, I think it was to highlight mixed licenses across files 😅 Could you align ?

leemannd · 2026-01-06T12:16:18Z

        )

    def test_parent_childs_project(self):
-        self.assertIn(self.project_project_2, self.project_project_1.child_ids)


I would keep it, but with assertNotIn

alexey-pelykh

Thanks for the migration!

A couple of things to address before this can go in:

License headers still inconsistent -- as @rousseldenis pointed out, the manifest and views declare LGPL-3, but the Python files (__init__.py, models/__init__.py, tests/__init__.py, models/project_project.py, tests/test_project_parent.py) and the demo XML use AGPL-3.0. Please align all files to match the manifest license (LGPL-3).
view_type key in action_open_child_project() -- "view_type": "form" was removed in Odoo 17+. This key should be dropped from the action dict.
t-esc in kanban view -- t-esc is deprecated since Odoo 17, please use t-out instead.
Test coverage -- as @leemannd suggested, it would be good to add an assertNotIn to verify that project_project_2 (which has no parent) is not in project_project_1.child_ids. The 18.0 version relied on demo data refs for this, so now that setup is manual, an explicit negative assertion strengthens the test.

alexey-pelykh · 2026-03-01T15:07:36Z

@@ -0,0 +1,42 @@
+# Copyright 2019 Therp BV <https://therp.nl>
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).


AGPL-3.0 header here but the manifest declares LGPL-3. Please align.

alexey-pelykh · 2026-03-01T15:07:36Z

+        return {
+            "type": "ir.actions.act_window",
+            "view_type": "form",
+            "name": f"Children of {self.name}",


"view_type": "form" was removed in Odoo 17. Please drop this key.

alexey-pelykh · 2026-03-01T15:07:36Z

+                position="inside"
+            >
+                <div class="o_primary">
+                    <span>


t-esc is deprecated since Odoo 17. Use t-out instead:

<t t-out="record.parent_id.value" />

alexey-pelykh · 2026-03-01T15:07:36Z

+        )
+
+    def test_parent_childs_project(self):
+        self.assertIn(self.project_project_3, self.project_project_1.child_ids)


Consider also asserting the negative case:

self.assertNotIn(self.project_project_2, self.project_project_1.child_ids)

This verifies that only actual children appear, not just that one child is present.

gdgellatly

Full Functional Test - works for me - Approve notwithstanding minor other comments from other reviewer to address

norlinhenrik · 2026-03-03T15:17:57Z

Thank you all for reviewing. I have added a commit with the changes.

alexey-pelykh

All four issues from the previous review are resolved:

License headers: all files now consistently use LGPL-3.0, matching the manifest.
view_type key: removed from action_open_child_project().
t-esc → t-out: updated in kanban view.
assertNotIn: negative assertion added to test.

CI is green. Thanks for the clean fix commit!

Co-Reviewed-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

OCA-git-bot · 2026-03-23T10:52:04Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BhaveshHeliconia

Functional review LGTM!

AaronHForgeFlow

Functional ok!

leemannd · 2026-05-04T08:16:01Z

/ocabot merge nobump

OCA-git-bot · 2026-05-04T08:16:09Z

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-1576-by-leemannd-bump-nobump, awaiting test results.

OCA-git-bot · 2026-05-04T08:21:03Z

Congratulations, your PR was merged at 5e40df6. Thanks a lot for contributing to OCA. ❤️

YogeshMahera-SerpentCS and others added 24 commits October 5, 2025 14:41

[ADD] - Added Project Parent module (OCA#326)

cefd5bb

[IMP/ADD]Added Child Project Smart button in parent project module

af9cefe

[MIG] Migrate project_parent from 10.0 to 12.0

a4c6aad

[UPD] [no task] parent_project v12

9743cfb

[IMP] project_parent: black, isort, prettier

4569506

parent_project mig to v13: Add test, refactore a bit project_parent_v…

c529842

…iews.xml, remove post_install file

parent_project mig to v13: Add project childs count + default_parent_…

027bd7c

…id on action

Translated using Weblate (Spanish)

4caabee

Currently translated at 100.0% (5 of 5 strings) Translation: project-13.0/project-13.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_parent/es/

[IMP] project_parent: pre-commit stuff

46c9288

[MIG] project_parent: Migration to 16.0

50ef8bc

Added translation using Weblate (Italian)

4532cbf

Translated using Weblate (Portuguese (Brazil))

4a61a8f

Currently translated at 80.0% (4 of 5 strings) Translation: project-16.0/project-16.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent/pt_BR/

Translated using Weblate (Spanish)

aa65190

Currently translated at 100.0% (6 of 6 strings) Translation: project-16.0/project-16.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent/es/

Translated using Weblate (Portuguese (Brazil))

e39d45b

Currently translated at 83.3% (5 of 6 strings) Translation: project-16.0/project-16.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent/pt_BR/

Added translation using Weblate (Dutch)

e369f99

[IMP] project_parent: pre-commit auto fixes

5b90034

[MIG] project_parent: Migration to 17.0

661f2f2

Translated using Weblate (Italian)

20f9292

Currently translated at 100.0% (6 of 6 strings) Translation: project-17.0/project-17.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-17-0/project-17-0-project_parent/it/

[IMP] project_parent: pre-commit auto fixes

87e2d76

[MIG] project_parent: Migration to 18.0

c12d927

[UPD] Update project_parent.pot

924127d

[BOT] post-merge updates

097a217

Added translation using Weblate (Portuguese)

15bf102

Translated using Weblate (Portuguese)

e62f515

Currently translated at 100.0% (6 of 6 strings) Translation: project-18.0/project-18.0-project_parent Translate-URL: https://translation.odoo-community.org/projects/project-18-0/project-18-0-project_parent/pt/

rousseldenis added needs review migration labels Oct 12, 2025

OCA-git-bot added this to the 19.0 milestone Oct 12, 2025

OCA-git-bot mentioned this pull request Oct 12, 2025

Migration to version 19.0 #1571

Open

42 tasks

rousseldenis reviewed Oct 12, 2025

View reviewed changes

norlinhenrik force-pushed the 19.0-mig-project_parent branch from d2fcb5c to e03fc7b Compare October 16, 2025 18:59

[MIG] project_parent: Migration to 19.0

5a9f4ed

norlinhenrik force-pushed the 19.0-mig-project_parent branch from e03fc7b to 5a9f4ed Compare October 16, 2025 19:08

leemannd reviewed Jan 6, 2026

View reviewed changes

alexey-pelykh requested changes Mar 1, 2026

View reviewed changes

gdgellatly approved these changes Mar 3, 2026

View reviewed changes

[FIX] project_parent: LGPL, t-out, assertNotIn, no view_type=form

5da761c

alexey-pelykh approved these changes Mar 23, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 23, 2026

BhaveshHeliconia approved these changes Mar 24, 2026

View reviewed changes

AaronHForgeFlow approved these changes Mar 24, 2026

View reviewed changes

CristianoMafraJunior approved these changes Mar 24, 2026

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 4, 2026

OCA-git-bot merged commit 486dc29 into OCA:19.0 May 4, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 4, 2026

		@@ -0,0 +1,42 @@
		# Copyright 2019 Therp BV <https://therp.nl>
		# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).

Uh oh!

Conversation

norlinhenrik commented Oct 5, 2025

Uh oh!

rousseldenis commented Oct 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdgellatly left a comment

Choose a reason for hiding this comment

Uh oh!

norlinhenrik commented Mar 3, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 23, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

leemannd commented May 4, 2026

Uh oh!

OCA-git-bot commented May 4, 2026

Uh oh!

Uh oh!

OCA-git-bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants