[IMP] pms: add active field to room.closure.reason#401
Merged
DarioLodeiros merged 1 commit intoMay 25, 2026
Conversation
Allow archiving room closure reasons that are no longer in use. Historical records that already reference an archived reason keep the link; the reason simply stops appearing in selection dropdowns for new closures. The form view exposes the standard "Archived" ribbon and a dedicated search view adds an "Archived" filter, wired to the menu action so it is reachable from the configuration menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activeBoolean field (defaultTrue) toroom.closure.reasonso reasons that are no longer in use can be archived without losing the link from historical records that already reference them.Motivation
Operations teams cycle through closure reason catalogues fairly often (renaming, splitting categories, etc.). Without
active, obsolete reasons stay visible in selection dropdowns forever and the only workaround is to delete them, which is not possible once historical closures reference them.Test plan
active=Trueafter the module update (default on the new column).pms.reservation/ out-of-service flows no longer include archived reasons by default.