Skip to content

[16.0][FIX] pms: skip cancel-by-modification reservations on confirm_all_reservations #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
May 24, 2026
+6 −1
Merged

[16.0][FIX] pms: skip cancel-by-modification reservations on confirm_all_reservations #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pms/models/pms_folio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1673,7 +1673,12 @@ def action_confirm(self):
)

if self.env.context.get("confirm_all_reservations"):
self.reservation_ids.action_confirm()
# Skip reservations cancelled because of a modification: re-confirming
# them would re-occupy the room of a superseded version of the same
# booking and trigger spurious availability errors.
self.reservation_ids.filtered(
lambda r: not (r.state == "cancel" and r.cancelled_reason == "modified")
).action_confirm()

return True

Expand Down
Loading