Open
Conversation
If multiple wizards are sending payrolls at the same time, every wizard acts in their own folder. Also add display name.
Contributor
|
Hi @peluko00, |
quirino95
approved these changes
Feb 13, 2026
quirino95
left a comment
quirino95
left a comment
There was a problem hiding this comment.
Code and functional review: LGTM
Suggestion (non-blocking): What do you think about keeping just the "Send" button instead of two? Of course, in this case, "Send" will do an asynchronous call. I think this is better for the user experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new module to process the payslips asynchronously.
I have also included a small improvement to allow multiple wizards to be processed at the same time without conflicts.
A more elaborate solution could be implemented (like using https://docs.python.org/3/library/tempfile.html) but that would require more refactoring.
Let me know what you think!