Skip to content

[ADD] hr_payroll_document_pymupdf: Try harder to read PDF payslip#241

Open
SirPyTech wants to merge 8 commits intoOCA:17.0from
PyTech-SRL:17.0-imp-hr_payroll_document-allow_override
Open

[ADD] hr_payroll_document_pymupdf: Try harder to read PDF payslip#241
SirPyTech wants to merge 8 commits intoOCA:17.0from
PyTech-SRL:17.0-imp-hr_payroll_document-allow_override

Conversation

@SirPyTech
Copy link

Forward port of #236, as requested in:

Can you put on v17 please @SirPyTech ?

Originally posted by @peluko00 in #236 (comment)

@OCA-git-bot
Copy link
Contributor

Hi @peluko00,
some modules you are maintaining are being modified, check this out!

@SirPyTech SirPyTech marked this pull request as ready for review December 29, 2025 11:43
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SirPyTech SirPyTech force-pushed the 17.0-imp-hr_payroll_document-allow_override branch from 72665f5 to c6cf691 Compare January 15, 2026 10:26
@SirPyTech
Copy link
Author

Rebased to fix conflicts.

A side note: in 16.0 the PyMuPDF dependency has been moved to its own module in order to keep hr_payroll_document more stable (no new dependency, see #236 (review)).
I think that from 17.0 onwards we could keep everything in hr_payroll_document, but it can be changed if needed.

@pedrobaeza
Copy link
Member

I still think it should be something separated, and more if this is for specific cases where the PDF is not parsed correctly with the existing library, but I won't block.

Copy link

@quirino95 quirino95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirPyTech
Copy link
Author

LGTM!

@peluko00 if you would like to merge please try the ocabot command, if it fails we'll include the repository maintainers in the loop: a module maintainer should be able to merge their module.

@peluko00
Copy link

I think the same as Pedro, maybe is better in a separate module.

@SirPyTech
Copy link
Author

I think the same as Pedro, maybe is better in a separate module.

Thanks for the update, I'll forward port the changes from 16.0 then, please remove your approval from the reviews.

@peluko00
Copy link

Can you separate as changes from 16.0 please @SirPyTech?

@SirPyTech
Copy link
Author

Can you separate as changes from 16.0 please @SirPyTech?

Yes, as I wrote yesterday:

I'll forward port the changes from 16.0

I'll work on this when I can

@SirPyTech SirPyTech force-pushed the 17.0-imp-hr_payroll_document-allow_override branch from c6cf691 to ad6ac52 Compare February 11, 2026 11:28
@SirPyTech SirPyTech changed the title [IMP] hr_payroll_document: Try harder to read PDF [ADD] hr_payroll_document_pymupdf: Try harder to read PDF payslip Feb 11, 2026
@SirPyTech SirPyTech requested a review from peluko00 February 11, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants