[FIX] maintenance_equipment_sequence: convert create to api.model_create_multi#564
Open
miquelrosell99 wants to merge 1 commit into
Conversation
…ate_multi Converts MaintenanceEquipmentCategory.create() and MaintenanceEquipment.create() to batch-compatible api.model_create_multi for Odoo 17 best practice.
Contributor
|
Hi @AdriaGForgeFlow, |
OCA-git-bot
added
series:17.0
mod:maintenance_equipment_sequence
dalonsod
suggested changes
May 20, 2026
Contributor
dalonsod
left a comment
dalonsod
left a comment
There was a problem hiding this comment.
See possible performance improvement comment
| vals["sequence_id"] = self.sudo()._create_sequence(vals).id | ||
| else: | ||
| vals["sequence_prefix"] = ( | ||
| self.env["ir.sequence"].browse(vals["sequence_id"]).prefix |
Contributor
There was a problem hiding this comment.
This line implies a browse() access for each for iteration. IMO it is desirable moving it outside for statement, make only one browse and manage result with a proper python dict within for.
| if equipment.category_id and not equipment.serial_no: | ||
| sequence_id = ( | ||
| self.env["maintenance.equipment.category"] | ||
| .browse(vals.get("category_id")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts MaintenanceEquipmentCategory.create() and MaintenanceEquipment.create() to batch-compatible api.model_create_multi for Odoo 17 best practice.