Skip to content

[19.0][IMP] maintenance_equipment_certification: improve expiration reminder#561

Open
JasminSForgeFlow wants to merge 1 commit into
OCA:19.0from
ForgeFlow:19.0-imp-maintenance_equipment_certification
Open

[19.0][IMP] maintenance_equipment_certification: improve expiration reminder#561
JasminSForgeFlow wants to merge 1 commit into
OCA:19.0from
ForgeFlow:19.0-imp-maintenance_equipment_certification

Conversation

@JasminSForgeFlow
Copy link
Copy Markdown

  • Fix email recipient: pass partner_ids via email_values so the To field is correctly populated instead of relying on template partner_to
  • Log an internal chatter note on the equipment record after each successful reminder send
  • Schedule a To-Do activity on the equipment when no technician or owner is assigned, so the gap is visible in the UI

@ForgeFlow

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @cubells,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:19.0 mod:maintenance_equipment_certification Module maintenance_equipment_certification labels May 14, 2026
Copy link
Copy Markdown

@MarinaAForgeFlow MarinaAForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-imp-maintenance_equipment_certification branch from 0d64a93 to fa647f4 Compare May 14, 2026 06:06
Copy link
Copy Markdown
Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM

Code review and test

- Fix email recipient: pass partner_ids via email_values so the To field
  is correctly populated instead of relying on template partner_to
- Log an internal chatter note on the equipment record after each
  successful reminder send
- Schedule a To-Do activity on the equipment when no technician or owner
  is assigned, so the gap is visible in the UI
@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-imp-maintenance_equipment_certification branch from fa647f4 to a5b967e Compare May 14, 2026 06:13
Copy link
Copy Markdown

@cgarcia-solvos cgarcia-solvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants