[19.0][MIG] mail_message_search: Migration to 19.0 #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostashiro
reviewed
Oct 1, 2025
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
Would you consider including this commit? OCA/social@6f374ca
| _inherit = "mail.message" | ||
|
|
||
| # Inherit field for update the store parameter. | ||
| record_name = fields.Char(store=True) |
Member
There was a problem hiding this comment.
IMO, we can drop the search on record_name as subject likely already includes that content in most cases.
bizzappdev
force-pushed
the
19.0-mig-mail_message_search-BAD
branch
from
ef77e7c to
bc06ea7
Compare
yostashiro
approved these changes
Oct 3, 2025
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
Code review. LGTM.
Would you consider including this commit? OCA/social@6f374ca
@bizzappdev In case you've missed this.
AungKoKoLin1997
approved these changes
Oct 3, 2025
Contributor
AungKoKoLin1997
left a comment
AungKoKoLin1997
left a comment
There was a problem hiding this comment.
Functional Review: LGTM
bizzappdev
force-pushed
the
19.0-mig-mail_message_search-BAD
branch
from
bc06ea7 to
a1f0960
Compare
Contributor
|
This PR has the |
Contributor
|
@bizzappdev Can you please include this fix in your PR? |
Currently translated at 100.0% (3 of 3 strings) Translation: social-16.0/social-16.0-mail_message_search Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_message_search/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mail-18.0/mail-18.0-mail_message_search Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_message_search/
Co-authored-by: Florent de Labarre <florent.mirieu@gmail.com>
bizzappdev
force-pushed
the
19.0-mig-mail_message_search-BAD
branch
from
a1f0960 to
f625648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in Odoo, the record_name field is not a stored field anymore. We have added stored true for the record_name field. TBD: Should we remove the search functionality for record_name? Or have it stored=True, in this case, we should already include the migration script and the init hook, in case we are considering record_name as a searchable field.