Skip to content

[18.0][MIG] mail_composer_cc_bcc_account: Migration to 18.0#4

Open
trisdoan wants to merge 11 commits intoOCA:18.0from
trisdoan:18.0-mig-mail_composer_cc_bcc_account
Open

[18.0][MIG] mail_composer_cc_bcc_account: Migration to 18.0#4
trisdoan wants to merge 11 commits intoOCA:18.0from
trisdoan:18.0-mig-mail_composer_cc_bcc_account

Conversation

@trisdoan
Copy link
Copy Markdown
Contributor

@trisdoan trisdoan commented Nov 12, 2024

Note

Changes in 18.0

  • Print & send was refactored in https://github.com/odoo/odoo/pull/180212
    => So, instead of patching account.move.send, adding cc/bcc support in account.move.send.wizard

@trisdoan trisdoan mentioned this pull request Nov 12, 2024
Open
38 tasks
@trisdoan trisdoan marked this pull request as draft December 11, 2024 11:21
@trisdoan
Copy link
Copy Markdown
Contributor Author

trisdoan commented Dec 11, 2024 •
edited
Loading

DRAFT: working on failed tests

@trisdoan trisdoan force-pushed the 18.0-mig-mail_composer_cc_bcc_account branch 3 times, most recently from 076cde7 to 3e395d9 Compare December 16, 2024 02:10
@trisdoan trisdoan marked this pull request as ready for review December 16, 2024 02:13
@AEstLo
Copy link
Copy Markdown

AEstLo commented Apr 4, 2025

@trisdoan I will happily review and test this module once is ready

@matteotognini
Copy link
Copy Markdown

matteotognini commented Apr 7, 2025

Hi @trisdoan, I would like to test this module. Could you please rebase to reload the runboat? Thanks

@trisdoan trisdoan force-pushed the 18.0-mig-mail_composer_cc_bcc_account branch from 3e395d9 to 5f7f087 Compare April 9, 2025 09:03
matteotognini
matteotognini approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown

@matteotognini matteotognini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional ok

AEstLo
AEstLo approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown

@AEstLo AEstLo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@matteotognini
Copy link
Copy Markdown

matteotognini commented Jun 10, 2025

Could it be possible to merge this?

@trisdoan
Copy link
Copy Markdown
Contributor Author

trisdoan commented Jun 11, 2025

Hello @pedrobaeza, could you merge this please?

@pedrobaeza pedrobaeza added this to the 18.0 milestone Jun 11, 2025
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Jun 11, 2025

A review by a PSC is needed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale label Oct 12, 2025
@github-actions github-actions Bot closed this Nov 16, 2025
@jdidderen jdidderen mentioned this pull request Dec 10, 2025
Open
@glasl
Copy link
Copy Markdown

glasl commented Jan 27, 2026

Can someone comment on the timeline for this module to be reviewed?

@AEstLo
Copy link
Copy Markdown

AEstLo commented Jan 27, 2026

maybe @StefanRijnhart can merge it?

StefanRijnhart
StefanRijnhart reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like adding cc/bcc to sending by batch is left out here (account.move.send.batch.wizard)? If so, please mention in the roadmap.

Comment thread mail_composer_cc_bcc_account/wizards/account_move_send_wizard.py
@StefanRijnhart
Copy link
Copy Markdown
Member

StefanRijnhart commented Jan 28, 2026

/ocabot migration mail_composer_cc_bcc_account

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jan 28, 2026

There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment.

@github-actions github-actions Bot removed the stale label Feb 1, 2026
@glasl glasl mentioned this pull request Feb 6, 2026
Open
@ChristophAbenthungCibex
Copy link
Copy Markdown
Contributor

ChristophAbenthungCibex commented Apr 15, 2026

any news?

ChristophAbenthungCibex
ChristophAbenthungCibex approved these changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChristophAbenthungCibex ChristophAbenthungCibex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and tested the module and it works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart left review comments

+3 more reviewers

@AEstLo AEstLo AEstLo approved these changes

@matteotognini matteotognini matteotognini approved these changes

@ChristophAbenthungCibex ChristophAbenthungCibex ChristophAbenthungCibex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

10 participants

@trisdoan @AEstLo @matteotognini @pedrobaeza @glasl @StefanRijnhart @OCA-git-bot @ChristophAbenthungCibex @NL66278 @mymage