Skip to content

[19.0][MIG] hr_expense_advance_clearing_sequence: Migration to 19.0#359

Draft
dnplkndll wants to merge 24 commits into
OCA:19.0from
ledoent:19.0-mig-hr_expense_advance_clearing_sequence
Draft

[19.0][MIG] hr_expense_advance_clearing_sequence: Migration to 19.0#359
dnplkndll wants to merge 24 commits into
OCA:19.0from
ledoent:19.0-mig-hr_expense_advance_clearing_sequence

Conversation

@dnplkndll
Copy link
Copy Markdown

Port of `hr_expense_advance_clearing_sequence` from 18.0 to 19.0. Trivial — moves the sheet-level advance sequence to per-expense.

Depends on OCA/hr-expense#353 (A2 hr_expense_sequence) + OCA/hr-expense#358 (D2 hr_expense_advance_clearing). Both pinned in `test-requirements.txt`.

Non-mechanical adaptations

  • Inherit `hr.expense` (was `hr.expense.sheet`); key off `expense_type == 'advance'` (was sheet's `advance` Boolean).
  • Sequence code renamed: `hr.expense.sheet.advance` → `hr.expense.advance`. Same `AV` prefix, same padding.
  • Test subclasses D2's `TestHrExpenseAdvanceClearing` so the sequence module inherits all of D2's fixtures + adds two cases (advance gets AV number; regular expense doesn't).

The `Detect unreleased dependencies` CI red is expected — `[DO NOT MERGE]` dep-pin to #353 + #358. Strip when both land.

ps-tubtim and others added 24 commits May 28, 2026 13:38
Currently translated at 100.0% (1 of 1 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_clearing_sequence
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_clearing_sequence/it/
- Inherit hr.expense (was hr.expense.sheet); key off expense_type='advance'
  (was sheet.advance Boolean).
- Sequence code renamed hr.expense.sheet.advance → hr.expense.advance.
- Test rewritten against per-expense flow; subclasses D2's TestHrExpenseAdvanceClearing.
…equence + hr_expense_advance_clearing to open PRs
@OCA-git-bot OCA-git-bot added series:19.0 mod:hr_expense_advance_clearing_sequence Module hr_expense_advance_clearing_sequence labels May 28, 2026
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_advance_clearing_sequence branch 2 times, most recently from 37290b1 to 611223e Compare May 29, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:hr_expense_advance_clearing_sequence Module hr_expense_advance_clearing_sequence series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants