Skip to content

[18.0][MIG] web_view_leaflet_map: Migration to 18.0#419

Merged
OCA-git-bot merged 27 commits intoOCA:18.0from
akretion:18.0-mig-web_view_leaflet_map
Nov 17, 2025
Merged

[18.0][MIG] web_view_leaflet_map: Migration to 18.0#419
OCA-git-bot merged 27 commits intoOCA:18.0from
akretion:18.0-mig-web_view_leaflet_map

Conversation

@mourad-ehm
Copy link
Contributor

@mourad-ehm mourad-ehm commented Oct 21, 2025

Migrate web_view_leaflet_map module from this pr #415

@tate11
Copy link

tate11 commented Oct 22, 2025

web.assets_web_dark.min.js:41 Uncaught Error: Error while loading "@web_view_leaflet_map/components/map-component/map_view.esm":
Error: Invalid object: 'type' is not valid
at ModuleLoader.startModule (web.assets_web_dark.min.js:41:227)
at ModuleLoader.startModules (web.assets_web_dark.min.js:40:57)
at ModuleLoader.addJob (web.assets_web_dark.min.js:5:39)
at ModuleLoader.define (web.assets_web_dark.min.js:10:121)
at web.assets_web_dark.min.js:22891:6
web.assets_web_dark.min.js:23 The following modules failed to load because of an error: Array(1)
reportErrors @ web.assets_web_dark.min.js:23
share-modal.js:1 Uncaught TypeError: Cannot read properties of null (reading 'addEventListener')
at share-modal.js:1:135

@thibaultrey thibaultrey force-pushed the 18.0-mig-web_view_leaflet_map branch from 75628c2 to ae08db6 Compare November 7, 2025 13:40
@mourad-ehm mourad-ehm changed the title WIP [18.0][MIG] web_view_leaflet_map: Migration to 18.0 [18.0][MIG] web_view_leaflet_map: Migration to 18.0 Nov 12, 2025
legalsylvain and others added 26 commits November 12, 2025 10:50
@legalsylvain @mourad-ehm
[ADD] web_view_leaflet_map
c01b7e2
@mourad-ehm
[UPD] Update web_view_leaflet_map.pot
ebb0145
@OCA-git-bot @mourad-ehm
[UPD] README.rst
eecf824
@OCA-git-bot @mourad-ehm
[ADD] icon.png
2367dc1
@legalsylvain @mourad-ehm
[IMP] web_view_leaflet_map: black, isort, prettier
cd38aff
@legalsylvain @mourad-ehm
[IMP] web_view_leaflet_map*: black, isort, prettier
ce3c1eb
@legalsylvain @mourad-ehm
[MIG] web_view_leaflet_map, web_view_leaflet_map_partner in V16
2be3907
@legalsylvain @mourad-ehm
[REF] Bump leaflet js library to 1.9.4, released on May 18, 2023. (fr…
b934b81 
…om 1.8.0, released on April 18, 2022.)
@mourad-ehm
[UPD] Update web_view_leaflet_map.pot
203515f
@weblate @mourad-ehm
Update translation files
5c69639 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map
Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/
@mymage @mourad-ehm
Added translation using Weblate (Italian)
79b114c
@mymage @mourad-ehm
Translated using Weblate (Italian)
9c642fa 
Currently translated at 100.0% (7 of 7 strings)

Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map
Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/it/
@legalsylvain @mourad-ehm
[REF] split web_view_leaflet_map into web_view_leaflet_map and web_le…
c921385 
…aflet_lib, to be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)
@OCA-git-bot @mourad-ehm
[BOT] post-merge updates
2423203
@mourad-ehm
[UPD] Update web_view_leaflet_map.pot
cb58702
@weblate @mourad-ehm
Update translation files
9fecc06 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map
Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/
@cesarportas @mourad-ehm
[IMP] web_view_leaflet_map: pre-commit auto fixes
b605ddc
@cesarportas @mourad-ehm
[17.0][MIG] web_view_leaflet_map: Refactor to OWL component
eca9c0e
@cesarportas @mourad-ehm
[17.0][MIG] web_view_leaflet_map: Refactor to OWL component
2844b03
@cesarportas @mourad-ehm
Revert "Importer gitlab work"
82524a8 
This reverts commit a9570109
@cesarportas @mourad-ehm
[17.0][MIG] web_view_leaflet_map: Refactor to OWL component
fa847d7
@cesarportas @mourad-ehm
[17.0][MIG] web_view_leaflet_map: Refactor to OWL component
e720f9b
@cesarportas @mourad-ehm
[17.0][MIG] web_view_leaflet_map: pre-commit fix
f087173
@mourad-ehm
[IMP] web_view_leaflet_map: pre-commit auto fixes
dc4f2d1
@mourad-ehm
[MIG] web_view_leaflet_map: Migration to 18.0
9f97191
@thibaultrey @mourad-ehm
[MIG] web_view_leaflet_map: fix view mode declaration for 18.0 migration
a4c2500
@mourad-ehm mourad-ehm force-pushed the 18.0-mig-web_view_leaflet_map branch from ae08db6 to a4c2500 Compare November 12, 2025 09:53
@mourad-ehm
Copy link
Contributor Author

mourad-ehm commented Nov 12, 2025

Hi @tate11, thanks for your review. The bug was fixed. could you test ?

NL66278
NL66278 reviewed Nov 13, 2025
View reviewed changes
@legalsylvain
Copy link
Contributor

legalsylvain commented Nov 17, 2025

Hi @mourad-ehm. Thanks for porting this module. I know that generaly, there is a module per PR, but in that case, could you also migrate trivial web_view_leaflet_map_partner module, so we can test on runboat, more easely ?

thanks !

@mourad-ehm
Copy link
Contributor Author

mourad-ehm commented Nov 17, 2025

Hi @legalsylvain, I have created this PR #420 for web_view_leaflet_map_partner.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 17, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@mourad-ehm mourad-ehm requested a review from NL66278 November 17, 2025 11:00
@legalsylvain
Copy link
Contributor

legalsylvain commented Nov 17, 2025

Hi. tested on #425 / runboat.
works like a charm.
thanks for porting this module.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 17, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-419-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 370808a into OCA:18.0 Nov 17, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 17, 2025

Congratulations, your PR was merged at 19507b5. Thanks a lot for contributing to OCA. ❤️

@bealdav bealdav deleted the 18.0-mig-web_view_leaflet_map branch November 17, 2025 11:44
@legalsylvain
Copy link
Contributor

legalsylvain commented Nov 18, 2025

Hi. I installed the module on odoo 18 instance, and it looks like there is a regression.
The search bar is not visible in the map view. (it was present in v16 and V12)
it is so not possible to filter...

image

Did you faced similar issue ?

@NL66278
Copy link
Contributor

NL66278 commented Nov 20, 2025

@legalsylvain Yes, I do not see a searchbar on 18.0. So same here.

@legalsylvain
Copy link
Contributor

legalsylvain commented Nov 20, 2025

@mourad-ehm. Could you take a look on that regression ?
Thanks !

@NL66278
Copy link
Contributor

NL66278 commented Nov 20, 2025

@legalsylvain @mourad-ehm I can get the map to show a searchbar with the attached patch. However it does not yet react to selected filters. So will need some more work, but I have not to much experience in owl how to do this, so maybe use this as a pointer to what might be needed?
searchbar.patch

@legalsylvain legalsylvain mentioned this pull request Jan 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NL66278 NL66278 Awaiting requested review from NL66278

2 more reviewers

@bealdav bealdav bealdav approved these changes

@thibaultrey thibaultrey thibaultrey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@mourad-ehm @tate11 @legalsylvain @OCA-git-bot @NL66278 @bealdav @thibaultrey @weblate @mymage @cesarportas

Comments